Page MenuHomePhabricator
Differential D10095

[lib] `ThreadInfo` -> `LegacyThreadInfo`
ClosedPublic
Actions

Authored by atul on Nov 29 2023, 8:43 PM.
Tags
None
Referenced Files
F3385216: D10095.diff
Thu, Nov 28, 11:47 PM
Unknown Object (File)
Mon, Nov 25, 12:48 PM
Unknown Object (File)
Mon, Nov 25, 11:51 AM
Unknown Object (File)
Sat, Nov 2, 5:01 AM
Unknown Object (File)
Fri, Nov 1, 10:29 PM
Unknown Object (File)
Wed, Oct 30, 10:21 PM
Unknown Object (File)
Oct 29 2024, 1:09 AM
Unknown Object (File)
Oct 6 2024, 9:39 AM
View All 98 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMcc7b87ee5eb0: [lib] `ThreadInfo` -> `LegacyThreadInfo`
Summary

Simple rename similar to eg D10077

Test Plan

flow/CI/etc.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 29 2023, 8:43 PM
Harbormaster completed remote builds in B24616: Diff 34017.Nov 29 2023, 9:03 PM
atul requested review of this revision.Nov 29 2023, 9:03 PM
tomek accepted this revision.Nov 30 2023, 1:23 AM

Accepting without review. What procedure did you use to rename all the types?

This revision is now accepted and ready to land.Nov 30 2023, 1:23 AM
atul added a comment.Nov 30 2023, 8:31 AM
In D10095#293995, @tomek wrote:

Accepting without review. What procedure did you use to rename all the types?

For renaming I'm just using the WebStorm Refactor -> Rename. However, diffs like D10068 I'm unfortunately doing by hand.. don't know a good way to "automate" that off the top of my head

atul added a child revision: D10122: [lib] Re-introduce `ThreadInfo` (`[Legacy/MinimallyEncoded]ThreadInfo`).Nov 30 2023, 4:02 PM
atul mentioned this in D10133: [lib] `ResolvedThreadInfo` -> `LegacyResolvedThreadInfo`.Dec 1 2023, 5:49 AM
Closed by commit rCOMMcc7b87ee5eb0: [lib] `ThreadInfo` -> `LegacyThreadInfo` (authored by atul). · Explain WhyDec 1 2023, 12:44 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMcc7b87ee5eb0: [lib] `ThreadInfo` -> `LegacyThreadInfo`.
atul mentioned this in rCOMM774b77618c90: [lib] `ResolvedThreadInfo` -> `LegacyResolvedThreadInfo`.

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
7 lines
lib/
components/
6 lines
hooks/
4 lines
10 lines
10 lines
4 lines
13 lines
4 lines
permissions/
4 lines
selectors/
44 lines
4 lines
79 lines
shared/
6 lines
10 lines
4 lines
4 lines
6 lines
16 lines
messages/
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
18 lines
4 lines
4 lines
4 lines
4 lines
8 lines
4 lines
20 lines
4 lines
6 lines
124 lines
4 lines
types/
messages/
4 lines
4 lines
4 lines
8 lines
45 lines
utils/
15 lines
15 lines
14 lines
4 lines
4 lines
native/
avatars/
7 lines
4 lines
calendar/
4 lines
4 lines
chat/
8 lines
4 lines
6 lines
16 lines
8 lines
6 lines
6 lines
13 lines
45 lines
4 lines
4 lines
4 lines
10 lines
4 lines
4 lines
6 lines
4 lines
10 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
settings/
4 lines
4 lines
4 lines
4 lines
7 lines
4 lines
4 lines
4 lines
4 lines
4 lines
7 lines
7 lines
4 lines
8 lines
4 lines
4 lines
4 lines
14 lines
8 lines
6 lines
8 lines
6 lines
10 lines
4 lines
4 lines
4 lines
4 lines
components/
4 lines
4 lines
4 lines
6 lines
7 lines
18 lines
4 lines
input/
34 lines
14 lines
invite-links/
4 lines
4 lines
keyboard/
4 lines
23 lines
8 lines
markdown/
4 lines
media/
4 lines
4 lines
navigation/
4 lines
4 lines
push/
6 lines
roles/
7 lines
6 lines
4 lines
4 lines
4 lines
search/
4 lines
4 lines
selectors/
6 lines
types/
14 lines
user-profile/
4 lines
4 lines
4 lines
utils/
4 lines
web/
avatars/
7 lines
7 lines
7 lines
7 lines
calendar/
6 lines
chat/
6 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
6 lines
6 lines
4 lines
4 lines
4 lines
4 lines
relationship-prompt/
4 lines
6 lines
4 lines
4 lines
4 lines
components/
4 lines
input/
32 lines
12 lines
invite-links/
manage/
4 lines
markdown/
4 lines
modals/
chat/
4 lines
4 lines
4 lines
search/
4 lines
4 lines
threads/
4 lines
create/
4 lines
steps/
9 lines
4 lines
gallery/
4 lines
members/
7 lines
7 lines
4 lines
settings/
4 lines
4 lines
7 lines
9 lines
7 lines
4 lines
user-profile/
4 lines
4 lines
4 lines
navigation-panels/
4 lines
6 lines
roles/
9 lines
4 lines
4 lines
4 lines
4 lines
selectors/
4 lines
8 lines
6 lines
sidebar/
4 lines
4 lines
4 lines
4 lines
types/
8 lines
utils/
4 lines
16 lines

Diff 34017

View Options

keyserver/src/push/send.js

Loading...
View Options

lib/components/chat-mention-provider.react.js

Loading...
View Options

lib/hooks/chat-mention-hooks.js

Loading...
View Options

lib/hooks/child-threads.js

Loading...
View Options

lib/hooks/promote-sidebar.react.js

Loading...
View Options

lib/hooks/relationship-prompt.js

Loading...
View Options

lib/hooks/search-threads.js

Loading...
View Options

lib/hooks/toggle-unread-status.js

Loading...
View Options

lib/permissions/minimally-encoded-thread-permissions-validators.js

Loading...
View Options

lib/selectors/chat-selectors.js

Loading...
View Options

lib/selectors/nav-selectors.js

Loading...
View Options

lib/selectors/thread-selectors.js

Loading...
View Options

lib/shared/ancestor-threads.js

Loading...
View Options

lib/shared/avatar-utils.js

Loading...
View Options

lib/shared/edit-messages-utils.js

Loading...
View Options

lib/shared/inline-engagement-utils.js

Loading...
View Options

lib/shared/mention-utils.js

Loading...
View Options

lib/shared/message-utils.js

Loading...
View Options

lib/shared/messages/add-members-message-spec.js

Loading...
View Options

lib/shared/messages/change-role-message-spec.js

Loading...
View Options

lib/shared/messages/change-settings-message-spec.js

Loading...
View Options

lib/shared/messages/create-entry-message-spec.js

Loading...
View Options

lib/shared/messages/create-sidebar-message-spec.js

Loading...
View Options

lib/shared/messages/create-sub-thread-message-spec.js

Loading...
View Options

lib/shared/messages/create-thread-message-spec.js

Loading...
View Options

lib/shared/messages/delete-entry-message-spec.js

Loading...
View Options

lib/shared/messages/edit-entry-message-spec.js

Loading...
View Options

lib/shared/messages/join-thread-message-spec.js

Loading...
View Options

lib/shared/messages/leave-thread-message-spec.js

Loading...
View Options

lib/shared/messages/message-spec.js

Loading...
View Options

lib/shared/messages/multimedia-message-spec.js

Loading...
View Options

lib/shared/messages/reaction-message-spec.js

Loading...
View Options

lib/shared/messages/remove-members-message-spec.js

Loading...
View Options

lib/shared/messages/restore-entry-message-spec.js

Loading...
View Options

lib/shared/messages/text-message-spec.js

Loading...
View Options

lib/shared/messages/update-relationship-message-spec.js

Loading...
View Options

lib/shared/notif-utils.js

Loading...
View Options

lib/shared/reaction-utils.js

Loading...
View Options

lib/shared/search-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/shared/user-utils.js

Loading...
View Options

lib/types/messages/create-sidebar.js

Loading...
View Options

lib/types/messages/create-subthread.js

Loading...
View Options

lib/types/messages/create-thread.js

Loading...
View Options

lib/types/minimally-encoded-thread-permissions-types.js

Loading...
View Options

lib/types/thread-types.js

Loading...
View Options

lib/utils/drawer-utils.react.js

Loading...
View Options

lib/utils/entity-helpers.js

Loading...
View Options

lib/utils/entity-text.js

Loading...
View Options

lib/utils/role-utils.js

Loading...
View Options

lib/utils/toggle-pin-utils.js

Loading...
View Options

native/avatars/edit-thread-avatar.react.js

Loading...
View Options

native/avatars/thread-avatar.react.js

Loading...
View Options

native/calendar/calendar.react.js

Loading...
View Options

native/calendar/entry.react.js

Loading...
View Options

native/chat/chat-context-provider.react.js

Loading...
View Options

native/chat/chat-context.js

Loading...
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/chat/chat-router.js

Loading...
View Options

native/chat/chat-thread-list-item.react.js

Loading...
View Options

native/chat/chat-thread-list-see-more-sidebars.react.js

Loading...
View Options

native/chat/chat-thread-list-sidebar.react.js

Loading...
View Options

native/chat/chat-thread-list.react.js

Loading...
View Options

native/chat/compose-subchannel.react.js

Loading...
View Options

native/chat/failed-send.react.js

Loading...
View Options

native/chat/fullscreen-thread-media-gallery.react.js

Loading...
View Options

native/chat/image-paste-modal.react.js

Loading...
View Options

native/chat/inline-engagement.react.js

Loading...
View Options

native/chat/inner-robotext-message.react.js

Loading...
View Options

native/chat/inner-text-message.react.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

native/chat/message-list-header-title.react.js

Loading...
View Options

native/chat/message-list-types.js

Loading...
View Options

native/chat/message-list.react.js

Loading...
View Options

native/chat/message-preview.react.js

Loading...
View Options

native/chat/message-result.react.js

Loading...
View Options

native/chat/message-results-screen.react.js

Loading...
View Options

native/chat/parent-thread-header.react.js

Loading...
View Options

native/chat/relationship-prompt.react.js

Loading...
View Options

native/chat/settings/add-users-modal.react.js

Loading...
View Options

native/chat/settings/color-selector-modal.react.js

Loading...
View Options

native/chat/settings/compose-subchannel-modal.react.js

Loading...
View Options

native/chat/settings/delete-thread.react.js

Loading...
View Options

native/chat/settings/emoji-thread-avatar-creation.react.js

Loading...
View Options

native/chat/settings/thread-settings-child-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-color.react.js

Loading...
View Options

native/chat/settings/thread-settings-description.react.js

Loading...
View Options

native/chat/settings/thread-settings-edit-relationship.react.js

Loading...
View Options

native/chat/settings/thread-settings-home-notifs.react.js

Loading...
View Options

native/chat/settings/thread-settings-leave-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-member-tooltip-modal.react.js

Loading...
View Options

native/chat/settings/thread-settings-member.react.js

Loading...
View Options

native/chat/settings/thread-settings-parent.react.js

Loading...
View Options

native/chat/settings/thread-settings-promote-sidebar.react.js

Loading...
View Options

native/chat/settings/thread-settings-push-notifs.react.js

Loading...
View Options

native/chat/settings/thread-settings-visibility.react.js

Loading...
View Options

native/chat/settings/thread-settings.react.js

Loading...
View Options

native/chat/sidebar-list-modal.react.js

Loading...
View Options

native/chat/sidebar-navigation.js

Loading...
View Options

native/chat/subchannels-list-modal.react.js

Loading...
View Options

native/chat/swipeable-thread.react.js

Loading...
View Options

native/chat/thread-list-modal.react.js

Loading...
View Options

native/chat/thread-settings-button.react.js

Loading...
View Options

native/chat/thread-settings-header-title.react.js

Loading...
View Options

native/chat/toggle-pin-modal.react.js

Loading...
View Options

native/chat/utils.js

Loading...
View Options

native/components/community-actions-button.react.js

Loading...
View Options

native/components/community-pill.react.js

Loading...
View Options

native/components/thread-ancestors-label.react.js

Loading...
View Options

native/components/thread-ancestors.react.js

Loading...
View Options

native/components/thread-list-thread.react.js

Loading...
View Options

native/components/thread-list.react.js

Loading...
View Options

native/components/thread-pill.react.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

native/input/input-state.js

Loading...
View Options

native/invite-links/manage-public-link-screen.react.js

Loading...
View Options

native/invite-links/view-invite-links-screen.react.js

Loading...
View Options

native/keyboard/keyboard-input-host.react.js

Loading...
View Options

native/keyboard/keyboard-state-container.react.js

Loading...
View Options

native/keyboard/keyboard-state.js

Loading...
View Options

native/markdown/rules.react.js

Loading...
View Options

native/media/chat-camera-modal.react.js

Loading...
View Options

native/media/media-gallery-keyboard.react.js

Loading...
View Options

native/navigation/nav-selectors.js

Loading...
View Options

native/navigation/subchannels-button.react.js

Loading...
View Options

native/push/push-handler.react.js

Loading...
View Options

native/roles/change-roles-screen.react.js

Loading...
View Options

native/roles/community-roles-screen.react.js

Loading...
View Options

native/roles/create-roles-screen.react.js

Loading...
View Options

native/roles/role-panel-entry.react.js

Loading...
View Options

native/roles/role-utils.react.js

Loading...
View Options

native/search/message-search.react.js

Loading...
View Options

native/search/search-messages-button.react.js

Loading...
View Options

native/selectors/calendar-selectors.js

Loading...
View Options

native/types/chat-types.js

Loading...
View Options

native/user-profile/user-profile-menu-button.react.js

Loading...
View Options

native/user-profile/user-profile-message-button.react.js

Loading...
View Options

native/user-profile/user-profile-relationship-button.react.js

Loading...
View Options

native/utils/drawer-utils.react.js

Loading...
View Options

web/avatars/edit-thread-avatar-menu.react.js

Loading...
View Options

web/avatars/edit-thread-avatar.react.js

Loading...
View Options

web/avatars/thread-avatar.react.js

Loading...
View Options

web/avatars/thread-emoji-avatar-selection-modal.react.js

Loading...
View Options

web/calendar/day.react.js

Loading...
View Options

web/chat/chat-input-bar.react.js

Loading...
View Options

web/chat/chat-message-list.react.js

Loading...
View Options

web/chat/chat-thread-list-item-menu.react.js

Loading...
View Options

web/chat/chat-thread-list-see-more-sidebars.react.js

Loading...
View Options

web/chat/composed-message.react.js

Loading...
View Options

web/chat/edit-message-provider.js

Loading...
View Options

web/chat/edit-text-message.react.js

Loading...
View Options

web/chat/failed-send.react.js

Loading...
View Options

web/chat/inline-engagement.react.js

Loading...
View Options

web/chat/message-preview.react.js

Loading...
View Options

web/chat/message-tooltip.react.js

Loading...
View Options

web/chat/message.react.js

Loading...
View Options

web/chat/multimedia-message.react.js

Loading...
View Options

web/chat/relationship-prompt/relationship-prompt.js

Loading...
View Options

web/chat/robotext-message.react.js

Loading...
View Options

web/chat/text-message.react.js

Loading...
View Options

web/chat/thread-menu.react.js

Loading...
View Options

web/chat/thread-top-bar.react.js

Loading...
View Options

web/components/message-result.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/input/input-state.js

Loading...
View Options

web/invite-links/manage/edit-link-modal.react.js

Loading...
View Options

web/markdown/rules.react.js

Loading...
View Options

web/modals/chat/message-results-modal.react.js

Loading...
View Options

web/modals/chat/sidebar-promote-modal.react.js

Loading...
View Options

web/modals/chat/toggle-pin-modal.react.js

Loading...
View Options

web/modals/search/message-search-modal.react.js

Loading...
View Options

web/modals/search/message-search-utils.react.js

Loading...
View Options

web/modals/threads/confirm-leave-thread-modal.react.js

Loading...
View Options

web/modals/threads/create/compose-subchannel-modal.react.js

Loading...
View Options

web/modals/threads/create/steps/subchannel-members-list.react.js

Loading...
View Options

web/modals/threads/create/steps/subchannel-members.react.js

Loading...
View Options

web/modals/threads/gallery/thread-settings-media-gallery.react.js

Loading...
View Options

web/modals/threads/members/change-member-role-modal.react.js

Loading...
View Options

web/modals/threads/members/member.react.js

Loading...
View Options

web/modals/threads/members/members-list.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-delete-confirmation-modal.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-delete-tab.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-modal.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-privacy-tab.react.js

Loading...
View Options

web/modals/threads/thread-picker-modal.react.js

Loading...
View Options

web/modals/user-profile/user-profile-action-buttons.react.js

Loading...
View Options

web/modals/user-profile/user-profile-menu.react.js

Loading...
View Options

web/modals/user-profile/user-profile-message-button.react.js

Loading...
View Options

web/navigation-panels/chat-thread-ancestors.react.js

Loading...
View Options

web/navigation-panels/nav-state-info-bar.react.js

Loading...
View Options

web/roles/community-roles-modal.react.js

Loading...
View Options

web/roles/create-roles-modal.react.js

Loading...
View Options

web/roles/delete-role-modal.react.js

Loading...
View Options

web/roles/role-actions-menu.react.js

Loading...
View Options

web/roles/role-panel-entry.react.js

Loading...
View Options

web/selectors/calendar-selectors.js

Loading...
View Options

web/selectors/chat-selectors.js

Loading...
View Options

web/selectors/thread-selectors.js

Loading...
View Options

web/sidebar/community-drawer-item-community-handlers.react.js

Loading...
View Options

web/sidebar/community-drawer-item-handlers.react.js

Loading...
View Options

web/sidebar/community-drawer-utils.react.js

Loading...
View Options

web/sidebar/subchannels-button.react.js

Loading...
View Options

web/types/nav-types.js

Loading...
View Options

web/utils/thread-utils.js

Loading...
View Options

web/utils/tooltip-action-utils.js

Loading...