[electron-update-server] Specify platform in docker compose
ClosedPublic
Actions

Authored by michal on Dec 5 2023, 8:37 AM.

Details

Reviewers

bartek

Commits

Summary

We need to specify the platform key in the docker compose file so that we build images for the correct platform for the aws ECS.

Test Plan

docker compose build, check if the image was built

Repository

rCOMM Comm

Branch

michal/update-server-release-fixes

Lint

No Lint Coverage

Unit

No Test Coverage

michal requested review of this revision.Dec 5 2023, 8:57 AM

docker compose build, check if the image was built

To make sure the platform is correct, you can use the following command

docker inspect commapp/electron-update-server:2.0 -f "{{.Os}}/{{.Architecture}}"

This revision is now accepted and ready to land.Dec 5 2023, 9:03 AM

services/electron-update-server/docker-compose.yml
4	I've already published 2.0. Should we bump this to 3.0?

services/electron-update-server/docker-compose.yml
4	Ah – seeing in the doc that bumping the version number is meant to happen after testing on staging That order seems a little strange to me though, since after publishing to Docker Hub, this step is kind of impossible to reverse, right?

services/electron-update-server/docker-compose.yml
4	Unlike npm, you can publish again with the same tag (overwrite the image). You can also delete image with specific tag on DockerHub (it is safe if it wasn't ever pulled). bumping the version number is meant to happen after testing on staging IMO this applies more to other services than to this one - I assume that when CI will be auto-deploying staging services, it should use some constant tag like "`staging`" - bumping version tag with every commit doesn't make sense Generally, the tag/version policy depends on us, it is supposed to be helpful, not to limit.
4	I've already published 2.0. Should we bump this to 3.0? I'd go with overwriting 2.0 if it wasn't ever used