This adds custom errors to the lambda function instead of panics.
Previously, we used anyhow for errors and expect when unwrapping result/option types. This has all been replaced by custom error types in a new file called error.rs
Depends on D10788
Details
Details
Tested on staging. Working properly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- identity-search
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/search-index-lambda/src/main.rs | ||
|---|---|---|
| 20 | I'll remove the pubs when I arc land | |
| services/search-index-lambda/src/error.rs | ||
|---|---|---|
| 16 ↗ | (On Diff #35974) | Wasn't completely sure about using this macro. Because StatusCode doesn't implement std::error, I use the #[error(ignore)]attribute as we use in services/blob/src/s3.rs for S3PathError |
Comment Actions
nice, much cleaner with the improved error handling. one thing i just realized -- do we have a task to track adding a search-index-lambda CI workflow? if not, we should make one and prioritize it i think
Comment Actions
Task for creating a CI workflow created at https://linear.app/comm/issue/ENG-6525/create-a-search-index-lambda-ci-workflow. Thanks for pointing this out.