Page MenuHomePhabricator
Differential D10765

[identity] Remove social proof from devices table
ClosedPublic
Actions

Authored by bartek on Jan 22 2024, 3:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 11:39 PM
Unknown Object (File)
Fri, Nov 8, 4:37 AM
Unknown Object (File)
Thu, Nov 7, 1:19 PM
Unknown Object (File)
Thu, Nov 7, 1:09 PM
Unknown Object (File)
Thu, Nov 7, 11:40 AM
Unknown Object (File)
Thu, Nov 7, 10:19 AM
Unknown Object (File)
Thu, Nov 7, 9:36 AM
Unknown Object (File)
Oct 18 2024, 3:43 AM
View All 48 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
will
michal
Commits
rCOMMe0a66e14acea: [identity] Remove social proof from devices table
Summary

Part 2 of ENG-6480.
Since the social proof is stored in the users table, we don't need to store it in the devices table.

Depends on D10764

Test Plan

Repeated test plan from D10764. Verified that the social proof is still retrieved correctly, especially in GetKeyserverKeys RPC (for which I changed the code).

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jan 22 2024, 3:08 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 3:08 AM
Harbormaster completed remote builds in B25988: Diff 35920.Jan 22 2024, 3:35 AM
bartek published this revision for review.Jan 22 2024, 3:52 AM
bartek added inline comments.
services/identity/src/database/device_list.rs
259–261

We agreed that we don't need social proof in IdentityKeyInfo returned from the GetXboundKeys RPCs so this field is going to be removed when we update the proto

varun accepted this revision.Jan 22 2024, 6:03 PM
This revision is now accepted and ready to land.Jan 22 2024, 6:03 PM
bartek added a child revision: D10793: [identity] Rename PreKey DB struct to Prekey.Jan 23 2024, 5:29 AM
Closed by commit rCOMMe0a66e14acea: [identity] Remove social proof from devices table (authored by bartek). · Explain WhyJan 26 2024, 8:33 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMe0a66e14acea: [identity] Remove social proof from devices table.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
2 lines
1 line
10 lines
database/
21 lines

Diff 35920

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/database/device_list.rs

Loading...