The users info is almost always correct in the case of an unknown error, so we shouldn't clear it. Had this thought while investigating ENG-8727, which I realized would have never occurred for me if we didn't do this.
Details
Details
- I tested the native login workflow by killing the keyserver and confirming that the user input wasn't cleared after I got the Unknown error alert
- To test the native legacy registration workflow while usingCSAT=true I had to hardcode the value of initialNotificationsEncryptedMessage. Otherwise did the same (kill keyserver and test)
- I skipped testing web since the changes were so minimal and killing the keyserver means I can't load it, so the testing would be slightly harder
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- ashoat/clearuserinput
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/account/log-in-panel.react.js | ||
---|---|---|
406 ↗ | (On Diff #42089) | We sometimes know what the error is. Maybe we should change the name to e.g. onOtherErrorAlertAcknowledged? |