Page MenuHomePhabricator

[native][web] Stop clearing user input on unknown error
ClosedPublic

Authored by ashoat on Jul 7 2024, 1:49 PM.
Tags
None
Referenced Files
F2839871: D12682.diff
Sun, Sep 29, 3:26 AM
Unknown Object (File)
Sun, Sep 22, 10:41 AM
Unknown Object (File)
Sun, Sep 8, 3:03 PM
Unknown Object (File)
Sun, Sep 8, 3:03 PM
Unknown Object (File)
Sun, Sep 8, 3:03 PM
Unknown Object (File)
Sun, Sep 8, 3:03 PM
Unknown Object (File)
Sun, Sep 8, 3:02 PM
Unknown Object (File)
Sat, Sep 7, 3:10 AM
Subscribers
None

Details

Summary

The users info is almost always correct in the case of an unknown error, so we shouldn't clear it. Had this thought while investigating ENG-8727, which I realized would have never occurred for me if we didn't do this.

Test Plan
  1. I tested the native login workflow by killing the keyserver and confirming that the user input wasn't cleared after I got the Unknown error alert
  2. To test the native legacy registration workflow while usingCSAT=true I had to hardcode the value of initialNotificationsEncryptedMessage. Otherwise did the same (kill keyserver and test)
  3. I skipped testing web since the changes were so minimal and killing the keyserver means I can't load it, so the testing would be slightly harder

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/clearuserinput
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested review of this revision.Jul 7 2024, 2:06 PM
tomek added inline comments.
native/account/log-in-panel.react.js
406 ↗(On Diff #42089)

We sometimes know what the error is. Maybe we should change the name to e.g. onOtherErrorAlertAcknowledged?

This revision is now accepted and ready to land.Jul 8 2024, 1:56 AM

Rename onUnknownErrorAlertAcknowledged to onOtherErrorAlertAcknowledged

This revision was landed with ongoing or failed builds.Jul 8 2024, 8:13 AM
This revision was automatically updated to reflect the committed changes.