diff --git a/lib/shared/thread-actions-utils.js b/lib/shared/thread-actions-utils.js --- a/lib/shared/thread-actions-utils.js +++ b/lib/shared/thread-actions-utils.js @@ -126,47 +126,41 @@ parentThreadID: threadInfo.parentThreadID, name: threadInfo.name, }); - } else { - invariant( - otherMemberIDs.length > 0, - 'otherMemberIDs should not be empty for threads', + } else if (threadTypeIsThick(threadInfo.type)) { + const type = assertThickThreadType( + pendingThreadType(otherMemberIDs.length, 'thick'), ); - if (threadTypeIsThick(threadInfo.type)) { - const type = assertThickThreadType( - pendingThreadType(otherMemberIDs.length, 'thick'), - ); - invariant( - type !== 16, - // Flow does not recognize that threadTypes.THICK_SIDEBAR is 16 - 'pendingThreadType should not return THICK_SIDEBAR', - ); - newThreadID = await createNewThickThread({ - type, - initialMemberIDs: otherMemberIDs, - color: threadInfo.color, - }); - newThreadType = type; - } else { - const type = assertThinThreadType( - pendingThreadType(otherMemberIDs.length, 'thin'), - ); + invariant( + type !== 16, + // Flow does not recognize that threadTypes.THICK_SIDEBAR is 16 + 'pendingThreadType should not return THICK_SIDEBAR', + ); + newThreadID = await createNewThickThread({ + type, + initialMemberIDs: otherMemberIDs, + color: threadInfo.color, + }); + newThreadType = type; + } else { + const type = assertThinThreadType( + pendingThreadType(otherMemberIDs.length, 'thin'), + ); - invariant( - type !== 5, // Flow does not recognize that threadTypes.SIDEBAR is 5 - 'pendingThreadType should not return SIDEBAR', - ); - resultPromise = createNewThinThread({ - type, - initialMemberIDs: otherMemberIDs, - color: threadInfo.color, - calendarQuery, - }); - void dispatchActionPromise(newThreadActionTypes, resultPromise); - const result = await resultPromise; - newThreadID = result.newThreadID; - newThreadType = type; - } + invariant( + type !== 5, // Flow does not recognize that threadTypes.SIDEBAR is 5 + 'pendingThreadType should not return SIDEBAR', + ); + resultPromise = createNewThinThread({ + type, + initialMemberIDs: otherMemberIDs, + color: threadInfo.color, + calendarQuery, + }); + void dispatchActionPromise(newThreadActionTypes, resultPromise); + const result = await resultPromise; + newThreadID = result.newThreadID; + newThreadType = type; } return { threadID: newThreadID,