Page MenuHomePhabricator
Differential D14000

[CommCoreModule][native_rust_library] move constants to one place
ClosedPublic
Actions

Authored by kamil on Fri, Nov 22, 2:15 AM.
Tags
None
Referenced Files
F3386627: D14000.id45938.diff
Fri, Nov 29, 5:26 AM
F3383919: D14000.id45941.diff
Thu, Nov 28, 6:18 PM
Unknown Object (File)
Thu, Nov 28, 10:22 AM
Unknown Object (File)
Wed, Nov 27, 8:13 PM
Unknown Object (File)
Wed, Nov 27, 5:09 AM
Unknown Object (File)
Tue, Nov 26, 3:07 PM
Unknown Object (File)
Tue, Nov 26, 1:05 AM
Unknown Object (File)
Mon, Nov 25, 3:40 PM
View All 9 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM5a5a75ae2939: [CommCoreModule][native_rust_library] move constants to one place
Summary

Part of ENG-9656

I'm not sure why it was previously defined in two places. It makes it hard to maintain, so I'm cleaning this up. I added the missing comment.

Depends on D13937

Test Plan

Tested creating backup and secondary device login

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Nov 22, 2:15 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Nov 22, 2:15 AM
kamil added a child revision: D14001: [backup-client] set `backupID` after uploading User Keys.Fri, Nov 22, 2:19 AM
Harbormaster failed remote builds in B32761: Diff 45937!Fri, Nov 22, 2:31 AM
kamil updated this revision to Diff 45940.Fri, Nov 22, 2:42 AM

build .wasm

Harbormaster completed remote builds in B32764: Diff 45940.Fri, Nov 22, 3:06 AM
kamil edited the summary of this revision. (Show Details)Fri, Nov 22, 3:56 AM
kamil published this revision for review.Fri, Nov 22, 4:01 AM
bartek accepted this revision.Sun, Nov 24, 11:20 PM
This revision is now accepted and ready to land.Sun, Nov 24, 11:20 PM
kamil updated this revision to Diff 45992.Mon, Nov 25, 3:38 AM

rebase before landing

Harbormaster completed remote builds in B32805: Diff 45992.Mon, Nov 25, 3:58 AM
Closed by commit rCOMM5a5a75ae2939: [CommCoreModule][native_rust_library] move constants to one place (authored by kamil). · Explain WhyMon, Nov 25, 4:07 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM5a5a75ae2939: [CommCoreModule][native_rust_library] move constants to one place.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
16 lines
Tools/
4 lines
native_rust_library/
src/
1 line
web/
shared-worker/
_generated/

Diff 46016

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/Tools/CommSecureStore.h

Loading...
View Options

native/native_rust_library/src/constants.rs

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...