Page MenuHomePhabricator
Differential D14059

[native] upload User Keys backup when user is staff
AcceptedPublic
Actions

Authored by kamil on Wed, Nov 27, 9:42 AM.
Tags
None
Referenced Files
F3393264: D14059.diff
Sat, Nov 30, 12:49 PM
Unknown Object (File)
Wed, Nov 27, 3:20 PM
Unknown Object (File)
Wed, Nov 27, 3:20 PM
Unknown Object (File)
Wed, Nov 27, 3:20 PM
Unknown Object (File)
Wed, Nov 27, 3:20 PM
Unknown Object (File)
Wed, Nov 27, 3:20 PM
Unknown Object (File)
Wed, Nov 27, 3:20 PM
Unknown Object (File)
Wed, Nov 27, 3:20 PM
View All 13 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Summary

Part of ENG-9604 but only for staff.

This is also needed for ENG-9711.

Depends on D14056

Test Plan
  1. Check if backup is uploaded when user has no backup
  2. Log out/in and check if backup is uploaded

Diff Detail

Repository
rCOMM Comm
Branch
backup-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Wed, Nov 27, 9:42 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Nov 27, 9:42 AM
kamil added a child revision: D14060: [native] add handler for staff to attempt backup restore.Wed, Nov 27, 9:45 AM
Harbormaster completed remote builds in B32887: Diff 46102.Wed, Nov 27, 9:59 AM
kamil published this revision for review.Wed, Nov 27, 10:22 AM
kamil added inline comments.
native/backup/backup-handler.js
57
97–98

dispatchActionPromise is swallowing errors, this is to avoid that

ashoat added inline comments.Wed, Nov 27, 3:09 PM
native/backup/backup-handler.js
101

Should we only show this alert to staff?

bartek accepted this revision.Fri, Nov 29, 2:56 AM
bartek added inline comments.
native/backup/backup-handler.js
101

Looks like it's the same as in https://phab.comm.dev/D14056#inline-78946 - it's gated on staffCanSee

This revision is now accepted and ready to land.Fri, Nov 29, 2:56 AM

Revision Contents
Changeset List

PathSize
native/
backup/
60 lines

Diff 46102

View Options

native/backup/backup-handler.js

Loading...