Details
Details
Log the steps and make sure order is correct and each step is executed only once. The rest is tested in the next diff in the stack
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/redux/initial-state-gate.js | ||
|---|---|---|
| 95–106 ↗ | (On Diff #47949) | Can 'client_store_dispatched' and 'client_store_ready' steps be merged together? We could then get rid of this additional effect and check for step.step !== 'client_store_ready' || !clientDBStateLoaded in the bottom effect. |
| 101 ↗ | (On Diff #47949) | Why do we need dependencies for dispatch and isRehydrated here? |
| web/redux/initial-state-gate.js | ||
|---|---|---|
| 95–106 ↗ | (On Diff #47949) | Following this up, I'd name this merged step client_store_dispatched and in the latter useEffect: const clientStoreReady = step.step === 'client_store_dispatched' && clientDBStateLoaded; if (!clientStoreReady) { return; } This will probably give maximum readability |
Comment Actions
address review
| web/redux/initial-state-gate.js | ||
|---|---|---|
| 95–106 ↗ | (On Diff #47949) | I did it a bit differently because otherwise Flow complains |