Differential D14698

[comm-lib] Add size and version info fields to BackupItem
ClosedPublic
Actions

Authored by bartek on May 13 2025, 3:08 PM.

Details

Reviewers

kamil

Commits

rCOMMca3685792c4c: [comm-lib] Add size and version info fields to BackupItem

Summary

Point 1 of ENG-10760.

Added backup size and version info to BackupItem struct which is shared between Backup and Identity Service.

Depends on D14685

Test Plan

unit test for deserialization, built both services and tested UserKeys restore flow.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 13 2025, 3:08 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 13 2025, 3:08 PM

bartek added a child revision: D14699: [comm-lib] Store backup size and version in DDB.May 13 2025, 3:09 PM

Harbormaster completed remote builds in B34167: Diff 48074.May 13 2025, 3:39 PM

bartek published this revision for review.May 15 2025, 8:02 AM

bartek added inline comments.

services/backup/src/http/handlers/backup.rs
61–63	These will be updated in subsequent diffs (ENG-10688)

kamil accepted this revision.May 15 2025, 8:32 AM

kamil added inline comments.

shared/comm-lib/src/backup/database.rs
226–227	Looks like there is a typo here

This revision is now accepted and ready to land.May 15 2025, 8:32 AM

Typo

Harbormaster completed remote builds in B34177: Diff 48086.May 15 2025, 12:49 PM

Use camel case for version info

Harbormaster completed remote builds in B34184: Diff 48093.May 15 2025, 4:15 PM

Closed by commit rCOMMca3685792c4c: [comm-lib] Add size and version info fields to BackupItem. · Explain WhyMay 19 2025, 1:52 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMca3685792c4c: [comm-lib] Add size and version info fields to BackupItem.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

http/

handlers/

backup.rs

9 lines

shared/

comm-lib/

src/

backup/

database.rs

43 lines

mod.rs

10 lines

Diff 48074

View Options

services/backup/src/http/handlers/backup.rs

View Options

shared/comm-lib/src/backup/database.rs

View Options

shared/comm-lib/src/backup/mod.rs

[comm-lib] Add size and version info fields to BackupItemClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48074

services/backup/src/http/handlers/backup.rs

shared/comm-lib/src/backup/database.rs

shared/comm-lib/src/backup/mod.rs

[comm-lib] Add size and version info fields to BackupItem
ClosedPublic
Actions

Revision Contents
Changeset List