Details
Build app, test closing and openning multiple times, logout/login
Diff Detail
- Repository
- rCOMM Comm
- Branch
- land
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/cpp/CommonCpp/DatabaseManagers/WebSQLiteConnectionManager.cpp | ||
|---|---|---|
| 41–43 ↗ | (On Diff #48147) | This comment is confusing here. The reader doesn't know why would we want to rekey here.
|
add comment
| native/cpp/CommonCpp/DatabaseManagers/WebSQLiteConnectionManager.cpp | ||
|---|---|---|
| 41–43 ↗ | (On Diff #48147) |
Done
My initial approach was that each platform-specific method should be pure virtual in SQLiteConnectionManager, to make SQLiteConnectionManager abstract and to consider this platform-specific behaviour on each of the derived classes, even if it is doing nothing, I thought it was better to do it explicitly inthe derived class with a meaningful comment |
| native/cpp/CommonCpp/DatabaseManagers/WebSQLiteConnectionManager.cpp | ||
|---|---|---|
| 41–43 ↗ | (On Diff #48147) |
Makes sense, thanks for explaining |