Page MenuHomePhabricator

[1/n][docs] add docs/ to .gitignore and .eslintignore
AbandonedPublic

Authored by ashoat on Feb 23 2022, 4:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 11:31 AM
Unknown Object (File)
Fri, Nov 8, 10:48 PM
Unknown Object (File)
Fri, Nov 8, 10:47 PM
Unknown Object (File)
Fri, Nov 8, 9:50 PM
Unknown Object (File)
Oct 7 2024, 8:48 AM
Unknown Object (File)
Oct 7 2024, 8:47 AM
Unknown Object (File)
Oct 7 2024, 7:54 AM
Unknown Object (File)
Sep 20 2024, 1:29 PM

Details

Summary

This is required to prevent errors when checking using eslint for docs folder. Scaffolding is to be added in subsequent diff.

Should not include node_modules and build folder for git, they can be compiled via yarn and yarn build respectively.

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Branch
lastday
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested changes to this revision.EditedFeb 24 2022, 10:05 AM

Are we sure we want to ignore eslint for the entire docs workspace?

I'm not sure what the docs directory looks like (eg is the only thing we're "providing" the markdown? is there any JS or anything that we're going to write?) so it's hard to know whether we should skip linting entirely

This revision now requires changes to proceed.Feb 24 2022, 10:05 AM
In D3275#88174, @atul wrote:

Are we sure we want to ignore eslint for the entire docs workspace?

I'm not sure what the docs directory looks like (eg is the only thing we're "providing" the markdown? is there any JS or anything that we're going to write?) so it's hard to know whether we should skip linting entirely

Agree with atul, we should be lining and using prettier in the docs. I know prettier auto formats markdown files in my editor.

ashoat abandoned this revision.
ashoat added a reviewer: anand.