Page MenuHomePhabricator

Rename server directory to keyserver
ClosedPublic

Authored by marcin on Mar 1 2022, 12:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 8:44 AM
Unknown Object (File)
Tue, Nov 19, 1:21 PM
Unknown Object (File)
Tue, Nov 19, 12:57 PM
Unknown Object (File)
Sat, Nov 16, 3:31 PM
Unknown Object (File)
Fri, Nov 8, 8:16 PM
Unknown Object (File)
Fri, Nov 8, 9:42 AM
Unknown Object (File)
Fri, Nov 8, 9:42 AM
Unknown Object (File)
Fri, Nov 8, 7:42 AM

Details

Summary

This diff represents set of files that location changed after renaming server to keyserver but didn't need additional changes link imports, error messages etc. CI should fail for this differential but we accept it since the following diff in the stack will fix it by providing changes in imports and error messages in files that need it. This decision weas made for reviewer convenience.

Test Plan

There is no test plan for this diff. We can assume it is correct if the following diff in the stack passes CI and makes android, web and iOS buildable.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-390
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 1 2022, 12:10 AM
Harbormaster failed remote builds in B7086: Diff 9979!

Change some deletions into rename

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 1 2022, 1:58 AM
Harbormaster failed remote builds in B7089: Diff 9982!
marcin requested review of this revision.Mar 1 2022, 2:44 AM
tomek added a reviewer: ashoat.

Phabricator isn't too helpful here: it displays just deletions and additions. I've checked this by opening changeset list with moved here and moved away entries.

Adding @ashoat as a reviewer here as @marcinwasowicz mentioned that it might be a good idea

This revision is now accepted and ready to land.Mar 1 2022, 5:40 AM

Retrigger Ci after rebase

Move gitignore changes to this diff

Merge diffs into one to pass eslint during arc land.

This revision was automatically updated to reflect the committed changes.