Page MenuHomePhabricator
Differential D3356

[web] Pull `getIconPosition` out of `toggleTooltip`
ClosedPublic
Actions

Authored by atul on Mar 7 2022, 11:10 AM.
Tags
None
Referenced Files
F3393249: D3356.diff
Sat, Nov 30, 12:44 PM
Unknown Object (File)
Wed, Nov 13, 12:38 PM
Unknown Object (File)
Wed, Nov 13, 12:37 PM
Unknown Object (File)
Oct 27 2024, 5:28 AM
Unknown Object (File)
Oct 27 2024, 5:28 AM
Unknown Object (File)
Oct 27 2024, 5:28 AM
Unknown Object (File)
Oct 27 2024, 5:28 AM
Unknown Object (File)
Oct 27 2024, 5:28 AM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
varun
• benschac
Commits
rCOMMd19789f31d76: [web] Pull `getIconPosition` out of `toggleTooltip`
Summary

NA

Test Plan

NA

Diff Detail

Repository
rCOMM Comm
Branch
feb24 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 7 2022, 11:10 AM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 7 2022, 11:10 AM
Harbormaster completed remote builds in B7189: Diff 10118.Mar 7 2022, 11:15 AM
atul requested review of this revision.Mar 7 2022, 11:15 AM
varun requested changes to this revision.Mar 7 2022, 11:21 AM
varun added inline comments.
web/chat/message-action-buttons.js
19–24

can't you add PositionInfo to the list of types directly above this import?

This revision now requires changes to proceed.Mar 7 2022, 11:21 AM
atul updated this revision to Diff 10120.Mar 7 2022, 11:27 AM

address feedback

atul marked an inline comment as done.Mar 7 2022, 11:27 AM
atul added inline comments.
web/chat/message-action-buttons.js
19–24

yeah, thanks for catching

Harbormaster completed remote builds in B7191: Diff 10120.Mar 7 2022, 11:34 AM
varun accepted this revision.Mar 7 2022, 1:10 PM
This revision is now accepted and ready to land.Mar 7 2022, 1:10 PM
atul updated this revision to Diff 10243.Mar 9 2022, 10:45 AM
atul marked an inline comment as done.

rebase before landing

Harbormaster completed remote builds in B7262: Diff 10243.Mar 9 2022, 10:50 AM
atul updated this revision to Diff 10244.Mar 9 2022, 10:51 AM

just for amend

This revision was landed with ongoing or failed builds.Mar 9 2022, 10:52 AM
Closed by commit rCOMMd19789f31d76: [web] Pull `getIconPosition` out of `toggleTooltip` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMd19789f31d76: [web] Pull `getIconPosition` out of `toggleTooltip`.
Harbormaster completed remote builds in B7263: Diff 10244.Mar 9 2022, 10:56 AM

Revision Contents
Changeset List

PathSize
web/
chat/
43 lines

Diff 10118

View Options

web/chat/message-action-buttons.js

Loading...