I think the idea here is that we don't want to block development of the backup service on auth, given it might take a while to get the identity service up and running. I think it's okay to remove this stuff from here now – it's still in Git history, so we can bring it back once we introduce the .proto for the identity service.

I guess the idea behind grpc when changing the proto is to never reuse the values and instead use new indexes when changing the shape. Not sure if it applies here (probably not as we're not using the service yet)

This revision is now accepted and ready to land.Mar 22 2022, 4:48 AM

In D3461#94508, @ashoat wrote:

I think the idea here is that we don't want to block development of the backup service on auth, given it might take a while to get the identity service up and running. I think it's okay to remove this stuff from here now – it's still in Git history, so we can bring it back once we introduce the .proto for the identity service.

exactly

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

tomek accepted this revision.Mar 25 2022, 8:45 AM

This revision is now accepted and ready to land.Mar 25 2022, 8:45 AM

Closed by commit rCOMM92c1f81fc0e5: [services] Backup - Update proto file (authored by • karol). · Explain WhyMar 28 2022, 12:58 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM92c1f81fc0e5: [services] Backup - Update proto file.

ashoat mentioned this in D3573: [draft][services][identity] Initial .proto file for identity service.Mar 30 2022, 11:20 PM