Page MenuHomePhabricator
Differential D3623

[web] Remove unused CSS selectors from `thread-settings-modal.css`
ClosedPublic
Actions

Authored by atul on Apr 5 2022, 11:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 12:46 PM
Unknown Object (File)
Wed, Nov 13, 3:59 AM
Unknown Object (File)
Sun, Nov 10, 5:42 AM
Unknown Object (File)
Oct 15 2024, 3:01 PM
Unknown Object (File)
Oct 13 2024, 9:50 PM
Unknown Object (File)
Oct 13 2024, 9:50 PM
Unknown Object (File)
Oct 13 2024, 9:50 PM
Unknown Object (File)
Oct 13 2024, 9:50 PM
View All Files
Subscribers
• abosh
• adrian
• benschac
• karol

Details

Reviewers
tomek
• jacek
ashoat
Commits
rCOMMab4844f485a0: [web] Remove unused CSS selectors from `thread-settings-modal.css`
Summary

Remove CSS selectors that are obviously unused.

Test Plan

IDE would give me a red squiggle in JSX if selector was missing.

Diff Detail

Repository
rCOMM Comm
Branch
april7clean (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 5 2022, 11:42 AM
Herald added subscribers: • abosh, • benschac, • karol, • adrian. · View Herald TranscriptApr 5 2022, 11:42 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 5 2022, 11:49 AM
Harbormaster failed remote builds in B7895: Diff 11072!
atul updated this revision to Diff 11073.Apr 5 2022, 11:56 AM

update

atul updated this revision to Diff 11074.Apr 5 2022, 11:59 AM

can cut another one, no longer corresponds to ol

Harbormaster failed remote builds in B7896: Diff 11073!Apr 5 2022, 12:07 PM
Harbormaster completed remote builds in B7897: Diff 11074.Apr 5 2022, 12:14 PM
atul requested review of this revision.Apr 5 2022, 12:14 PM
ashoat accepted this revision.Apr 5 2022, 7:40 PM

I don't have enough context to judge whether your test plan is sufficient, but I'm pretty skeptical. If you're sure your IDE can be trusted to catch any and all, then I defer to you

This revision is now accepted and ready to land.Apr 5 2022, 7:40 PM
atul updated this revision to Diff 11122.Apr 6 2022, 12:04 PM

rebase

Harbormaster failed remote builds in B7935: Diff 11122!Apr 6 2022, 1:42 PM
atul updated this revision to Diff 11181.Apr 7 2022, 8:20 AM

rebase so can land this without D3622 which was blocked

Harbormaster failed remote builds in B7977: Diff 11181!Apr 7 2022, 8:53 AM
Harbormaster completed remote builds in B7977: Diff 11181.Apr 7 2022, 10:33 AM
Closed by commit rCOMMab4844f485a0: [web] Remove unused CSS selectors from `thread-settings-modal.css` (authored by atul). · Explain WhyApr 7 2022, 10:34 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMab4844f485a0: [web] Remove unused CSS selectors from `thread-settings-modal.css`.
atul mentioned this in D3622: [web] Convert `thread-settings-modal.css` selectors to use snake_case instead of dash-case.Apr 7 2022, 10:53 AM

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
61 lines

Diff 11181

View Options

web/modals/threads/thread-settings-modal.css

Loading...