update eslint config to ignore files, rather than add the comments, https://eslint.org/docs/user-guide/configuring/ignoring-code
Details
Details
go to webpack files, red swiggles are now gone.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D3761
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
How about lib/webpack/shared.cjs? Furthermore: if the ESLint parser simply can't handle CommonJS, should we just disable it for all .cjs files?
Is there a way to get this to work by configuring ESLint to treat .cjs files as CommonJS? Have you tried /* eslint-env commonjs */ annotation, or any of the other strategies described here?
Comment Actions
I tried: /* eslint-env commonjs */ annotation but that didn't work.
I think what makes the most sense is having the the
/* eslint-disable no-undef */ /* eslint-disable flowtype/require-valid-file-annotation */
annotation. If we just completely ignorePatterns the file like I had before eslint isn't enforcing anything. Using the disable no-undef and flow type we're just disabling features we don't need / use.
Comment Actions
Let's try to go through this in person at some point. You may be right but I want to step through it with you and make sure there isn't a better solution here. Can you remind on Monday? (Or alternately, feel free to preemptively book some time on Monday)
Comment Actions
Update to use ESLint overrides config to set .cjs files to commonjs and node env, and to disable Flow rules as well
Comment Actions
@benschac, keep in mind when landing this that you'll need to arc patch to get my latest revision. (Alternately, if you prefer I can commandeer, you can accept, and then I can land)
Comment Actions
@ashoat, you should probably commandeer at this point. You did the implementation while I watched. Happy to take it if that's easier for you though.