Page MenuHomePhabricator
Differential D3787

[services] Backup - Pull more mutual code from base reactors - Apply in server reactors
ClosedPublic
Actions

Authored by • karol on Apr 20 2022, 3:49 AM.
Tags
None
Referenced Files
F3350505: D3787.id11657.diff
Fri, Nov 22, 10:53 PM
F3350374: D3787.id11712.diff
Fri, Nov 22, 10:10 PM
Unknown Object (File)
Tue, Nov 19, 2:59 AM
Unknown Object (File)
Tue, Nov 19, 2:59 AM
Unknown Object (File)
Tue, Nov 19, 2:59 AM
Unknown Object (File)
Tue, Nov 19, 12:29 AM
Unknown Object (File)
Mon, Nov 11, 1:21 AM
Unknown Object (File)
Tue, Nov 5, 4:17 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
ashoat
Commits
rCOMM6bafbe2cce50: [services] Backup - Pull more mutual code from base reactors - Apply in server…
Summary

Depends on D3786

https://linear.app/comm/issue/ENG-916/consider-pulling-more-mutual-code-from-the-async-reactors

Applying inheriting the BaseRactor in the server reactors

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Apr 20 2022, 3:49 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 20 2022, 3:49 AM
• karol edited the summary of this revision. (Show Details)Apr 20 2022, 3:55 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3786: [services] Backup - Pull more mutual code from base reactors - Apply in client reactors.
Harbormaster completed remote builds in B8347: Diff 11657.Apr 20 2022, 3:57 AM
• karol requested review of this revision.Apr 20 2022, 3:57 AM
• karol added a child revision: D3788: [services] Blob - Pull more mutual code from base reactors - Add base reactor.Apr 20 2022, 4:04 AM
• karol mentioned this in D3719: [services] Backup - client reactors - distinguish terminated from done.Apr 20 2022, 4:22 AM
• karol planned changes to this revision.Apr 20 2022, 5:32 AM
• karol updated this revision to Diff 11662.Apr 20 2022, 5:32 AM
• karol edited the summary of this revision. (Show Details)

update

Harbormaster completed remote builds in B8352: Diff 11662.Apr 20 2022, 5:37 AM
ashoat requested changes to this revision.Apr 20 2022, 7:59 PM

Let's find a way to avoid using multiple inheritance, see comment in D3786

This revision now requires changes to proceed.Apr 20 2022, 7:59 PM
• karol updated this revision to Diff 11712.Apr 21 2022, 3:11 AM

rebase

Harbormaster completed remote builds in B8396: Diff 11712.Apr 21 2022, 3:17 AM
ashoat requested changes to this revision.Apr 21 2022, 10:14 AM

When you update a diff for a rebase without addressing comments, please hit "Plan Changes" to remove that diff from your reviewers' queue

This revision now requires changes to proceed.Apr 21 2022, 10:14 AM
• karol updated this revision to Diff 11788.Apr 22 2022, 5:08 AM

rebase

• karol planned changes to this revision.Apr 22 2022, 5:08 AM
Harbormaster completed remote builds in B8449: Diff 11788.Apr 22 2022, 5:14 AM
• karol mentioned this in D3789: [services] Blob - Pull more mutual code from base reactors - Apply in server reactors.Apr 22 2022, 5:15 AM
• karol added a comment.Apr 22 2022, 5:20 AM
In D3787#104878, @ashoat wrote:

Let's find a way to avoid using multiple inheritance, see comment in D3786

planned changes because of this

• karol updated this revision to Diff 12040.Apr 28 2022, 7:03 AM

new version of stack

Harbormaster completed remote builds in B8649: Diff 12040.Apr 28 2022, 7:15 AM
ashoat accepted this revision.Apr 28 2022, 11:55 AM
This revision is now accepted and ready to land.Apr 28 2022, 11:55 AM
Closed by commit rCOMM6bafbe2cce50: [services] Backup - Pull more mutual code from base reactors - Apply in server… (authored by • karol). · Explain WhyMay 5 2022, 1:47 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM6bafbe2cce50: [services] Backup - Pull more mutual code from base reactors - Apply in server….

Revision Contents
Changeset List

PathSize
services/
backup/
src/
Reactors/
server/
5 lines
base-reactors/
63 lines
88 lines
49 lines

Diff 12263

View Options

services/backup/src/Reactors/server/SendLogReactor.cpp

Loading...
View Options

services/backup/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

Loading...
View Options

services/backup/src/Reactors/server/base-reactors/ServerReadReactorBase.h

Loading...
View Options

services/backup/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Loading...