Page MenuHomePhabricator

[web] Fix `canSeePrivacyTab` logic in `ThreadSettingsModal`
ClosedPublic

Authored by atul on May 5 2022, 12:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 12:47 PM
Unknown Object (File)
Fri, Nov 8, 12:47 PM
Unknown Object (File)
Sun, Nov 3, 4:48 PM
Unknown Object (File)
Sun, Nov 3, 1:28 PM
Unknown Object (File)
Sun, Nov 3, 1:28 PM
Unknown Object (File)
Sun, Nov 3, 1:28 PM
Unknown Object (File)
Oct 10 2024, 3:24 AM
Unknown Object (File)
Oct 10 2024, 3:24 AM

Details

Summary

Logic was originally introduced to hide privacy tab for subthreads/subchannels that were "promoted" from sidebars: https://github.com/CommE2E/comm/commit/57588fae748567e0d73e5a85dd2eb536d14e8caf

Context for that logic is here: https://phabricator.ashoat.com/D1000?id=3007#inline-5622

Diff where threadInfo.sourceMessageID condition was flipped is here: https://github.com/CommE2E/comm/commit/0cfdd365eed90bef77bcc630a7076ce73d5ec2ad

Test Plan

Able to see the "Privacy" tab on subthreads/subchannels that were created directly... not able to see the "Privacy" tab on threads that were originally sidebars

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage