bump packages in web folder
Details
- Reviewers
atul tomek - Commits
- rCOMM027afc303a76: [chore] [web] bump fortawesome in web directory
open components like filter-panel.react that use the fortawesome icon package.
run yarn upgrade-interactive select @fortawesome packages in web
Diff Detail
- Repository
- rCOMM Comm
- Branch
- chore-bump-fort-awesome-web
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Didn't we already handle this in D3936?
We should make sure we keep the versions in sync across the yarn workspaces
We should make sure we keep the versions in sync across the yarn workspaces
This is critical. If yarn upgrade-interactive doesn't make it easy to do this we should avoid using it. In general I'm a bit skeptical of tools like that, as I worry they hide complexity from the user that is necessary to understand in order to do the work well. I tend to simply edit yarn.lock and package.json files directory when I want something changed. I always try to go through all package.json files as well as all relevant entires in yarn.lock in order to look for inconsistencies
I think it's pretty easy. The caveat is just to select all of the workspaces using the npm package when doing an update. Which I didn't do last time because I thought making the smallest possible change was the goal, and then testing in isolation. I can add this to the dev notes if that seems reasonable.
I think nobody reads Dev Notes, and I think you're the only one who uses yarn upgrade-interactive, so probably the only value of documenting is if it's useful for you