Cleaned up run_server_image.sh with style fixes and some double quoting to safely prevent globbing and word splitting. More details in inline comments.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/scripts/run_server_image.sh | ||
|---|---|---|
| 6 ↗ | (On Diff #13967) | Changed this to "arguments" to match lines 7 and 9. Arguments seems to be the correct term for this use case (elements following the command/positional parameters), whereas parameters seems to describe something that can provide information to a flag or option. Either way, this should match what's on lines 7 and 9. |
| 16 ↗ | (On Diff #13967) | Use -n instead of ! -z. This is a style fix, but it's the equivalent of removing a double negation when not necessary (since -n checks to see if a string is non-empty). |
| 20 ↗ | (On Diff #13967) | |
| 24 ↗ | (On Diff #13967) | |
| 32 ↗ | (On Diff #13967) | |