Page MenuHomePhabricator
Differential D4543

[services] Backup - Add unit test for getUtf8Length
AbandonedPublic
Actions

Authored by • jakub on Jul 15 2022, 1:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 4:50 PM
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:28 PM
Unknown Object (File)
Fri, Nov 8, 8:10 AM
Unknown Object (File)
Thu, Nov 7, 4:52 PM
Unknown Object (File)
Tue, Nov 5, 2:05 AM
Unknown Object (File)
Thu, Oct 31, 11:43 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• karol
tomek

Details

Reviewers
tomek
• karol
Summary

Depends on D4544

Add unit test for function for getting proper length of string encoded in utf8 multibyte format.

Test Plan

cd services && yarn run-unit-tests backup

Diff Detail

Repository
rCOMM Comm
Branch
unittest
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jakub created this revision.Jul 15 2022, 1:55 AM
Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 15 2022, 1:55 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2022, 1:57 AM
Harbormaster failed remote builds in B10548: Diff 14513!
• jakub edited the summary of this revision. (Show Details)Jul 15 2022, 3:02 AM
• jakub edited the summary of this revision. (Show Details)
• jakub added a parent revision: D4544: [services] Backup - Add function to get utf8 string length.
• jakub added reviewers: tomek, • karol.Jul 15 2022, 3:23 AM
• jakub updated this revision to Diff 14521.Jul 15 2022, 5:05 AM

Adding missing <algorithm> library

• jakub edited the summary of this revision. (Show Details)Jul 15 2022, 5:06 AM
• jakub edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B10553: Diff 14521.Jul 15 2022, 5:17 AM
• jakub requested review of this revision.Jul 15 2022, 5:17 AM
ashoat added a comment.Jul 17 2022, 7:22 AM

Can you make sure that lines don't exceed 80 chars?

• karol requested changes to this revision.Jul 18 2022, 2:08 AM
• karol added inline comments.
services/backup/test/ToolsTest.cpp
113

I think we do not want to use random data for tests. Tests should be constructed so we can easily repeat them. I think the data sets should be just hardcoded.

148

please, add a new line

This revision now requires changes to proceed.Jul 18 2022, 2:08 AM
• jakub updated this revision to Diff 14979.Jul 26 2022, 7:18 AM

Replacing random data sets with already generated examples

Harbormaster failed remote builds in B10892: Diff 14979!Jul 26 2022, 7:18 AM
• karol accepted this revision.Jul 27 2022, 4:47 AM
This revision is now accepted and ready to land.Jul 27 2022, 4:47 AM
tomek requested changes to this revision.Jul 27 2022, 5:06 AM
tomek added inline comments.
services/backup/test/ToolsTest.cpp
24–26 ↗(On Diff #14979)

What is the reason for putting the last two chars in their own lines? I guess the string can fit in one line.

83 ↗(On Diff #14979)

Doesn't matter that much, but we don't need to copy the data during iteration

This revision now requires changes to proceed.Jul 27 2022, 5:06 AM
• jakub abandoned this revision.Jul 27 2022, 9:05 AM

Abandoning, explained in previous diff D4544

Revision Contents
Changeset List

PathSize
services/
backup/
test/
147 lines

Diff 14521

View Options

services/backup/test/ToolsTest.cpp

Loading...