[Services] Update backup to reference new proto location
ClosedPublic
Actions

Authored by • jon on Sep 2 2022, 5:21 PM.

Details

Reviewers

atul
• karol
• abosh
• max

Commits

rCOMMa6da7e9a47c1: [Services] Update backup to reference new proto location

Summary

Update backup to reference the new protobuf
file locations.

https://linear.app/comm/issue/ENG-1231

Test Plan

nix develop
cd services/backup
rm -rf build && mkdir build && cd build && cmake .. && make -j

Backup CI gate passes

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Sep 2 2022, 5:21 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 2 2022, 5:21 PM

Harbormaster completed remote builds in B11859: Diff 16272.Sep 2 2022, 5:29 PM

• jon requested review of this revision.Sep 2 2022, 5:29 PM

• jon added a child revision: D5046: [Native] Remove old protos and related files.Sep 2 2022, 5:41 PM

Get a bunch of these when I try following the Test Plan:

/Users/atul/comm/services/backup/build/protos/backup.pb.cc:2033:11: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
  userid_.Swap(&other->userid_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~~ ^
/Users/atul/comm/services/backup/build/protos/backup.pb.cc:2034:13: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
  backupid_.Swap(&other->backupid_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~~~~ ^
/Users/atul/comm/services/backup/build/protos/backup.pb.cc:2452:22: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
  attachmentholders_.Swap(&other->attachmentholders_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~~~~~~~~~~~~~ ^
/Users/atul/comm/services/backup/build/protos/backup.pb.cc:2767:11: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
  userid_.Swap(&other->userid_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~~ ^
/Users/atul/comm/services/backup/build/protos/backup.pb.cc:2768:13: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
  backupid_.Swap(&other->backupid_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~~~~ ^
/Users/atul/comm/services/backup/build/protos/backup.pb.cc:2769:10: error: no member named 'Swap' in 'google::protobuf::internal::ArenaStringPtr'
  logid_.Swap(&other->logid_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());
  ~~~~~~ ^

Let me know if I'm missing anything here

This revision now requires changes to proceed.Sep 6 2022, 1:04 AM

• jon edited the summary of this revision. (Show Details)Sep 6 2022, 7:33 AM

• jon added a parent revision: D4992: [Shared] Copy protos to shared/protos, adjust CMake.Sep 6 2022, 9:13 AM

Rebase on master