Page MenuHomePhabricator
Differential D5225

[services] create ecr repository for identity service docker images
AbandonedPublic
Actions

Authored by varun on Sep 23 2022, 1:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 4, 12:39 AM
Unknown Object (File)
Feb 24 2024, 7:47 AM
Unknown Object (File)
Feb 24 2024, 7:41 AM
Unknown Object (File)
Feb 24 2024, 6:16 AM
Unknown Object (File)
Feb 5 2024, 6:33 PM
Unknown Object (File)
Jan 27 2024, 2:59 AM
Unknown Object (File)
Jan 27 2024, 2:59 AM
Unknown Object (File)
Jan 27 2024, 2:59 AM
View All 41 Files
Subscribers
• abosh
ashoat
atul

Details

Reviewers
tomek
• jon
atul
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

create an ECR repo called "services/identity" (figured we should use the services namespace to avoid future issues) in our account registry. allow tag mutability for now to work out the kinks. eventually we may want to make tags immutable.

Test Plan

terraform validate

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Sep 23 2022, 1:15 PM
Herald added a reviewer: • jon. · View Herald TranscriptSep 23 2022, 1:15 PM
Herald added subscribers: • abosh, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B12428: Diff 17065.Sep 23 2022, 1:22 PM
varun requested review of this revision.Sep 23 2022, 1:22 PM
tomek accepted this revision.Sep 26 2022, 3:15 AM

It would be great if you could explain why it is needed.

ashoat added a comment.Sep 26 2022, 4:49 AM

Yeah, agree with @tomek... I think this diff needs a lot more context:

  1. A Linear task should exist for it
  2. There should be some explanation of what an AWS ECR repository is and why we need it (appears to be specifically for Docker images)
  3. Discussion of alternatives should be included (eg. Docker Hub)
atul added a reviewer: Restricted Owners Package.Sep 26 2022, 8:34 AM
atul removed a reviewer: Restricted Owners Package.
atul edited reviewers, added: Restricted Owners Package; removed: atul.Sep 26 2022, 8:43 AM
atul requested changes to this revision.Sep 26 2022, 6:20 PM
atul added a subscriber: atul.
In D5225#153794, @ashoat wrote:

Yeah, agree with @tomek... I think this diff needs a lot more context:

  1. A Linear task should exist for it
  2. There should be some explanation of what an AWS ECR repository is and why we need it (appears to be specifically for Docker images)
  3. Discussion of alternatives should be included (eg. Docker Hub)

Requesting changes until these are addressed to take this off my queue for now

This revision now requires changes to proceed.Sep 26 2022, 6:20 PM
varun abandoned this revision.Aug 10 2023, 6:40 AM

Revision Contents
Changeset List

PathSize
services/
terraform/
4 lines

Diff 17065

View Options

services/terraform/ecr.tf

Loading...