Page MenuHomePhabricator

[native] added react-native-svg-transformer dev dependency
AbandonedPublic

Authored by ginsu on Sep 28 2022, 9:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 7:24 PM
Unknown Object (File)
Wed, Mar 20, 7:24 PM
Unknown Object (File)
Wed, Mar 20, 7:23 PM
Unknown Object (File)
Wed, Mar 20, 7:23 PM
Unknown Object (File)
Feb 24 2024, 7:47 AM
Unknown Object (File)
Feb 24 2024, 7:47 AM
Unknown Object (File)
Feb 24 2024, 7:41 AM
Unknown Object (File)
Feb 24 2024, 6:16 AM

Details

Reviewers
atul
ashoat
Summary

added react-native-svg-transformer dev dependency so we can import svg icons

React Native SVG transformer github link

Link for why we need this to import svg icons:
How to import SVG files in React Native using react-native-svg


Linear Issue: ENG-1779

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

removed native_rust_library files

ginsu added reviewers: atul, ashoat.
ginsu edited the summary of this revision. (Show Details)
ginsu requested review of this revision.Sep 28 2022, 9:28 AM
atul requested changes to this revision.Sep 28 2022, 9:33 AM

I'd take a look at native/components/background-tab-illustration.react.js to see how we're integrating SVG assets in the native app today.

(We generated that component w/ https://react-svgr.com/playground/)

This revision now requires changes to proceed.Sep 28 2022, 9:33 AM

Okay I got it now, will abandon and go with that implementation method