plain
ClosedPublic
Actions

Authored by tomek on Mar 3 2023, 4:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 30, 8:46 PM

	Unknown Object (File)
	Thu, Mar 28, 4:58 AM

	Unknown Object (File)
	Thu, Mar 28, 4:58 AM

	Unknown Object (File)
	Thu, Mar 28, 4:57 AM

	Unknown Object (File)
	Thu, Mar 28, 4:51 AM

	Unknown Object (File)
	Mar 15 2024, 6:55 PM

	Unknown Object (File)
	Feb 21 2024, 4:00 AM

	Unknown Object (File)
	Feb 21 2024, 4:00 AM

View All 44 Files

Subscribers

ashoat

atul

Details

Reviewers

kamil
bartek
• jon
varun

Commits

rCOMMe7c8b960558a: [services][feature-flags] Serve application/json instead of text/plain

Summary

It is a more maintainable solution.

Depends on D6886

Test Plan

Send GET using curl and check if the response looks correct.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Mar 3 2023, 4:24 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 3 2023, 4:24 AM

tomek added a child revision: D6948: [native] Create feature flags context.Mar 3 2023, 4:27 AM

Harbormaster completed remote builds in B17090: Diff 23398.Mar 3 2023, 4:39 AM

tomek requested review of this revision.Mar 3 2023, 4:39 AM

bartek accepted this revision.Mar 3 2023, 6:15 AM

This revision is now accepted and ready to land.Mar 3 2023, 6:15 AM

Closed by commit rCOMMe7c8b960558a: [services][feature-flags] Serve application/json instead of text/plain (authored by tomek). · Explain WhyMar 3 2023, 9:02 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMe7c8b960558a: [services][feature-flags] Serve application/json instead of text/plain.

Revision Contents
Changeset List

Path

Size

services/

feature-flags/

src/

service.rs

16 lines

Diff 23406

View Options

services/feature-flags/src/service.rs

[services][feature-flags] Serve application/json instead of text/plainClosedPublicActions