Page MenuHomePhabricator

[lib][keyserver] Add editing message type to messageTypes
ClosedPublic

Authored by kuba on Mar 7 2023, 1:34 AM.
Tags
None
Referenced Files
F1431032: D6962.id24216.diff
Thu, Mar 28, 1:05 AM
F1431031: D6962.id23475.diff
Thu, Mar 28, 1:05 AM
F1431030: D6962.id24394.diff
Thu, Mar 28, 1:05 AM
F1431004: D6962.id.diff
Thu, Mar 28, 1:04 AM
F1430956: D6962.diff
Thu, Mar 28, 12:55 AM
Unknown Object (File)
Feb 21 2024, 4:03 AM
Unknown Object (File)
Feb 20 2024, 11:32 PM
Unknown Object (File)
Feb 20 2024, 11:32 PM
Subscribers

Details

Summary

Registered new message type EDIT_MESSAGE to messageTypes. Added some lines to prevent flow-typing errors in different places of the app. For now, when we process the added
message type, we ignore it.

Test Plan

Tested if app compiles and checked if everything works correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Accepting, but if what I suggested doesn't take too long might be worthwhile to update

lib/shared/messages/sidebar-source-message-spec.js
108–114 ↗(On Diff #23475)

When I was working on reactions, @tomek recommended defining a set of incompatible messages with the sidebar source. Now that we have more than two incompatible messages, now might be a good time to address this

https://linear.app/comm/issue/ENG-2422/define-set-of-incompatible-message-types-for-sidebar-source

This revision is now accepted and ready to land.Mar 9 2023, 10:04 AM

Rebase to master

lib/shared/messages/sidebar-source-message-spec.js
108–114 ↗(On Diff #23475)

Added as follow-up task to message editing