Page MenuHomePhabricator

[web-db] implement types for `SubtleCrypto` module
ClosedPublic

Authored by kamil on Mar 7 2023, 9:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2024, 1:57 AM
Unknown Object (File)
Feb 20 2024, 11:40 PM
Unknown Object (File)
Feb 20 2024, 11:40 PM
Unknown Object (File)
Feb 20 2024, 11:39 PM
Unknown Object (File)
Feb 20 2024, 11:39 PM
Unknown Object (File)
Feb 13 2024, 2:38 AM
Unknown Object (File)
Feb 13 2024, 12:19 AM
Unknown Object (File)
Feb 13 2024, 12:13 AM
Subscribers

Details

Summary

There are no build in flow types for SubtleCrypto or any implementation we can use.

Adding types based on API docs and typescript.

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Branch
db-on-web-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Mar 7 2023, 10:08 AM
web/database/utils/crypto-types.js
138–263

Why aren't these ones read-only?

268–269

Why aren't these ones read-only?

web/database/utils/crypto-types.js
4

Can this be read-only?

improve types and move to flow-typed

kamil added a subscriber: bartek.

Previous types were too general (string instead of current algorithm names). I've updated this to be more precise (like D7023) but with specific types for the entire module - not only AES algorithms.

Checked if it works with D7024 (cc. @bartek).

LGTM, Works with my changes. Thank you for taking care of this!

This revision is now accepted and ready to land.Mar 12 2023, 11:48 PM