Page MenuHomePhabricator

[lib][keyserver] Introduce new threadPermissions types for reactions
ClosedPublic

Authored by ashoat on Mar 14 2023, 8:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 8, 6:52 PM
Unknown Object (File)
Thu, Mar 7, 7:26 AM
Unknown Object (File)
Tue, Mar 5, 11:35 PM
Unknown Object (File)
Feb 19 2024, 3:33 AM
Unknown Object (File)
Feb 19 2024, 12:09 AM
Unknown Object (File)
Feb 18 2024, 11:45 PM
Unknown Object (File)
Feb 18 2024, 6:53 PM
Unknown Object (File)
Feb 7 2024, 9:44 PM
Subscribers

Details

Summary

I want to allow people to react in announcement channels even though they can't send messages, so I'm introducing a new threadPermissions type.

This diff introduces the type, adds it to all roles except GENESIS members, and adds a new migration to populate it.

Test Plan

I tested this in combination with the next diff by:

  1. Running the migration by restarting the keyserver after introducing it and making sure it runs successfully
  2. Testing reacting as a member (non-admin) to a message in a COMMUNITY_ANNOUNCEMENT_ROOT community root. I don't have permission to send messages, but I can react on both native and web. I didn't need to log out / back in on native, which indicates the the updatesTypes.UPDATE_THREAD updates were propagated correctly by the migration

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable