[native] Use a JSON blob for heightMeasurerKey
ClosedPublic
Actions

Authored by ashoat on Mar 17 2023, 9:29 AM.

Tags

None

Referenced Files

	F1627854: D7093.id24055.diff
	Mon, Apr 22, 3:40 AM

	F1627853: D7093.id23823.diff
	Mon, Apr 22, 3:40 AM

	F1627846: D7093.id.diff
	Mon, Apr 22, 3:40 AM

	F1627833: D7093.diff
	Mon, Apr 22, 3:35 AM

	Unknown Object (File)
	Wed, Apr 10, 4:22 AM

	Unknown Object (File)
	Sat, Apr 6, 10:19 AM

	Unknown Object (File)
	Fri, Mar 29, 6:50 AM

	Unknown Object (File)
	Mar 8 2024, 1:35 AM

View All 57 Files

Subscribers

tomek

Details

Reviewers

atul
ginsu

Commits

rCOMM4765c224e781: [native] Use a JSON blob for heightMeasurerKey

Summary

Context on Linear.

Test Plan

Make sure we don't see height measurement errors when running the app on iOS simulator
Make sure that messages actually render when running the app on iOS simulator

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 17 2023, 9:29 AM

Herald added a subscriber: tomek. · View Herald TranscriptMar 17 2023, 9:29 AM

Harbormaster completed remote builds in B17387: Diff 23823.Mar 17 2023, 9:44 AM

ashoat requested review of this revision.Mar 17 2023, 9:44 AM

ginsu accepted this revision.Mar 17 2023, 11:12 AM

This revision is now accepted and ready to land.Mar 17 2023, 11:12 AM

Closed by commit rCOMM4765c224e781: [native] Use a JSON blob for heightMeasurerKey (authored by ashoat). · Explain WhyMar 23 2023, 8:17 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4765c224e781: [native] Use a JSON blob for heightMeasurerKey.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-item-height-measurer.react.js

6 lines

Diff 24055

View Options

native/chat/chat-item-height-measurer.react.js

[native] Use a JSON blob for heightMeasurerKeyClosedPublicActions