Page MenuHomePhabricator
Differential D7720

[Tunnelbroker] Define undelivered-messages table in rust
ClosedPublic
Actions

Authored by • jon on May 4 2023, 10:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 3:18 AM
Unknown Object (File)
Thu, Apr 18, 3:18 AM
Unknown Object (File)
Thu, Apr 18, 3:18 AM
Unknown Object (File)
Thu, Apr 18, 3:18 AM
Unknown Object (File)
Thu, Apr 18, 3:18 AM
Unknown Object (File)
Thu, Apr 18, 3:12 AM
Unknown Object (File)
Wed, Apr 3, 5:18 AM
Unknown Object (File)
Tue, Apr 2, 10:08 PM
View All 43 Files
Subscribers
atul
tomek

Details

Reviewers
varun
bartek
ashoat
Commits
rCOMMb76141925bbf: [Tunnelbroker] Define undelivered-messages table in rust
Summary

Describe the table in rust.
Part of: https://linear.app/comm/issue/ENG-3822

Test Plan

N/A, this is able design

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.May 4 2023, 10:51 AM
Herald added subscribers: atul, tomek. · View Herald TranscriptMay 4 2023, 10:51 AM
Harbormaster completed remote builds in B19052: Diff 26086.May 4 2023, 11:09 AM
• jon requested review of this revision.May 4 2023, 11:09 AM
ashoat accepted this revision.May 4 2023, 11:32 AM
ashoat added 1 blocking reviewer(s): varun.

Looks good to me but I'm pretty ignorant on DDB... would be great if @varun could take a look

varun accepted this revision.May 4 2023, 2:14 PM
varun added inline comments.
services/tunnelbroker/src/constants.rs
25 ↗(On Diff #26086)

pub const SORT_KEY?

This revision is now accepted and ready to land.May 4 2023, 2:14 PM
• jon added a parent revision: D7718: [Tunnelbroker] Create undelivered messages table.May 5 2023, 1:37 PM
• jon updated this revision to Diff 26318.May 9 2023, 11:31 PM

Add SORT_KEY alias

Harbormaster completed remote builds in B19219: Diff 26318.May 9 2023, 11:48 PM
• jon added a child revision: D7768: [Tunnelbroker] Encapsulate message handling with Session object.May 9 2023, 11:58 PM
• jon marked an inline comment as done.May 12 2023, 4:28 PM
• jon updated this revision to Diff 26429.May 12 2023, 4:33 PM

Rebase on master

Harbormaster completed remote builds in B19315: Diff 26429.May 12 2023, 4:50 PM
Closed by commit rCOMMb76141925bbf: [Tunnelbroker] Define undelivered-messages table in rust (authored by • jon). · Explain WhyMay 24 2023, 2:36 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMb76141925bbf: [Tunnelbroker] Define undelivered-messages table in rust.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
19 lines

Diff 27021

View Options

services/tunnelbroker/src/constants.rs

Loading...