Context in ENG-3897.
To fix problem adding condition if media_infos is empty array (which should prevent calling translateClientDBMediaInfosToMedia for non-media messages.
Details
Details
- Reviewers
tomek atul - Commits
- rCOMM7b3dc8969c6d: [lib] fix pinned content for non-media messages
Check on physical device and prod backend if error disappeared.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- fix-pin
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/utils/message-ops-utils.js | ||
|---|---|---|
| 111–112 | Hm, so we should also see why an empty media_infos array could have even "gotten" here? It looks like something like this:  would be the right answer. I would totally put up a diff making that change, but I'd need to do a LOT more testing to make sure that the change won't introduce another set of issues. I think what you have here is the best bet for now. | |
| lib/utils/message-ops-utils.js | ||
|---|---|---|
| 111–112 |
Yeah, I tested this previously while investigating and this code you linked is the "source" of those empty arrays. | |