Page MenuHomePhabricator

[landing] introduce signal competitor data
ClosedPublic

Authored by ginsu on May 22 2023, 5:53 AM.
Tags
None
Referenced Files
F1430878: D7904.id.diff
Wed, Mar 27, 11:54 PM
Unknown Object (File)
Wed, Mar 6, 9:48 AM
Unknown Object (File)
Feb 10 2024, 7:04 PM
Unknown Object (File)
Feb 10 2024, 7:04 PM
Unknown Object (File)
Feb 10 2024, 7:04 PM
Unknown Object (File)
Feb 10 2024, 7:04 PM
Unknown Object (File)
Feb 10 2024, 7:04 PM
Unknown Object (File)
Feb 10 2024, 7:03 PM
Subscribers

Details

Summary

This diff introduces the competitor data for signal which will be used in the competitor comparison. Right now I only have copy for Signal, but there is a Linear task to track the other competitors. As the tasks get completed, I will update the document accordingly

Depends on D8015

Test Plan

Read through carefully and will be further tested in subsequent diffs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu added reviewers: atul, kamil.
ginsu edited the summary of this revision. (Show Details)
landing/competitor-data.js
8–9 ↗(On Diff #26767)

These description are for the cards

10–11 ↗(On Diff #26767)

These descriptions are for the modal

ginsu requested review of this revision.May 22 2023, 6:12 AM

Assuming @ashoat has signed off on copy + we're fine with having lines extend past 80 characters since this is a "data" file vs. "code" file?

This revision is now accepted and ready to land.May 22 2023, 8:29 AM

I'm guessing this is the copy from DES-79, in which case I wrote it. RE line lengths, I guess it's fine

landing/competitor-data.js
22 ↗(On Diff #26767)

Typo

ginsu edited the summary of this revision. (Show Details)

address comments and remove logoImageURL field (since we are using svgs now)

Assuming @ashoat has signed off on copy + we're fine with having lines extend past 80 characters since this is a "data" file vs. "code" file?

Yes this was copy and pasted directly from DES-79 (sorry should have made that super clear) and investor-data.js also had lines that extended past 80 characters so I assumed this was okay

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

update double quote character

This revision was automatically updated to reflect the committed changes.