Page MenuHomePhabricator

[web] Changed edit modal overlay opacity
ClosedPublic

Authored by kuba on May 23 2023, 1:06 AM.
Tags
None
Referenced Files
F1440132: D7930.id26958.diff
Thu, Mar 28, 9:27 PM
F1440131: D7930.id26882.diff
Thu, Mar 28, 9:27 PM
F1440130: D7930.id26941.diff
Thu, Mar 28, 9:27 PM
F1440129: D7930.id26835.diff
Thu, Mar 28, 9:27 PM
F1440128: D7930.id26855.diff
Thu, Mar 28, 9:27 PM
F1440127: D7930.id26889.diff
Thu, Mar 28, 9:27 PM
F1440063: D7930.id.diff
Thu, Mar 28, 9:26 PM
F1439991: D7930.diff
Thu, Mar 28, 9:18 PM

Details

Summary
Test Plan

Checked if new opacity is applied in edit mode. Checked if it is not applied in other modals.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks like @ted suggested using two different opacities for modals here. My first instinct would be to just have a single opacity, but he's on vacation so we can just proceed with this approach for now

lib/components/modal-overlay.react.js
59 ↗(On Diff #26855)

This should be memoized. By passing in this new object every time, you've actually made all of the memoization above completely useless (memoization of onBackgroundMouseDown, onBackgroundMouseUp, and onKeyDown is now useless)

Can you remove the color from modal-overlay.css and set the default in ModalOverlay? I feel this will be more readable.

Moved default background color

This revision is now accepted and ready to land.May 23 2023, 7:53 AM
lib/components/modal-overlay.react.js
59 ↗(On Diff #26889)

Shorthand