Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F32368245
D3664.1765324697.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Size
5 KB
Referenced Files
None
Subscribers
None
D3664.1765324697.diff
View Options
diff --git a/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h b/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h
--- a/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h
+++ b/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h
@@ -25,6 +25,7 @@
: public grpc::ServerBidiReactor<Request, Response> {
Request request;
Response response;
+ bool finished = false;
protected:
ServerBidiReactorStatus status;
@@ -66,12 +67,16 @@
if (!this->status.status.ok()) {
std::cout << "error: " << this->status.status.error_message() << std::endl;
}
+ if (this->finished) {
+ return;
+ }
if (this->status.sendLastResponse) {
this->StartWriteAndFinish(
&this->response, grpc::WriteOptions(), this->status.status);
} else {
this->Finish(this->status.status);
}
+ this->finished = true;
}
template <class Request, class Response>
diff --git a/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h b/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h
--- a/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h
+++ b/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h
@@ -13,6 +13,7 @@
template <class Request, class Response>
class ServerReadReactorBase : public grpc::ServerReadReactor<Request> {
Request request;
+ bool finished = false;
void terminate(grpc::Status status);
@@ -39,7 +40,11 @@
if (!this->status.ok()) {
std::cout << "error: " << this->status.error_message() << std::endl;
}
+ if (this->finished) {
+ return;
+ }
this->Finish(status);
+ this->finished = true;
}
template <class Request, class Response>
diff --git a/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h b/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
--- a/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
+++ b/services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
@@ -14,6 +14,7 @@
class ServerWriteReactorBase : public grpc::ServerWriteReactor<Response> {
Response response;
bool initialized = false;
+ bool finished = false;
void terminate(grpc::Status status);
@@ -42,7 +43,11 @@
std::cout << "error: " << this->status.error_message() << std::endl;
}
this->status = status;
+ if (this->finished) {
+ return;
+ }
this->Finish(status);
+ this->finished = true;
}
template <class Request, class Response>
diff --git a/services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h b/services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h
--- a/services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h
+++ b/services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h
@@ -25,6 +25,7 @@
: public grpc::ServerBidiReactor<Request, Response> {
Request request;
Response response;
+ bool finished = false;
protected:
ServerBidiReactorStatus status;
@@ -66,12 +67,16 @@
if (!this->status.status.ok()) {
std::cout << "error: " << this->status.status.error_message() << std::endl;
}
+ if (this->finished) {
+ return;
+ }
if (this->status.sendLastResponse) {
this->StartWriteAndFinish(
&this->response, grpc::WriteOptions(), this->status.status);
} else {
this->Finish(this->status.status);
}
+ this->finished = true;
}
template <class Request, class Response>
diff --git a/services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h b/services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h
--- a/services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h
+++ b/services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h
@@ -13,6 +13,7 @@
template <class Request, class Response>
class ServerReadReactorBase : public grpc::ServerReadReactor<Request> {
Request request;
+ bool finished = false;
void terminate(grpc::Status status);
@@ -39,7 +40,11 @@
if (!this->status.ok()) {
std::cout << "error: " << this->status.error_message() << std::endl;
}
+ if (this->finished) {
+ return;
+ }
this->Finish(status);
+ this->finished = true;
}
template <class Request, class Response>
diff --git a/services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h b/services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
--- a/services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
+++ b/services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
@@ -14,6 +14,7 @@
class ServerWriteReactorBase : public grpc::ServerWriteReactor<Response> {
Response response;
bool initialized = false;
+ bool finished = false;
void terminate(grpc::Status status);
@@ -42,7 +43,11 @@
std::cout << "error: " << this->status.error_message() << std::endl;
}
this->status = status;
+ if (this->finished) {
+ return;
+ }
this->Finish(status);
+ this->finished = true;
}
template <class Request, class Response>
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Dec 9, 11:58 PM (14 h, 18 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5858951
Default Alt Text
D3664.1765324697.diff (5 KB)
Attached To
Mode
D3664: [services] Backup/Blob - Make sure Finish is only called once
Attached
Detach File
Event Timeline
Log In to Comment