Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F32447395
D9359.1765363627.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Size
2 KB
Referenced Files
None
Subscribers
None
D9359.1765363627.diff
View Options
diff --git a/native/components/full-screen-view-modal.react.js b/native/components/full-screen-view-modal.react.js
--- a/native/components/full-screen-view-modal.react.js
+++ b/native/components/full-screen-view-modal.react.js
@@ -22,9 +22,8 @@
import { type Dimensions } from 'lib/types/media-types.js';
-import SWMansionIcon from './swmansion-icon.react.js';
+import SWMansionIcon from '../components/swmansion-icon.react.js';
import ConnectedStatusBar from '../connected-status-bar.react.js';
-import Multimedia from '../media/multimedia.react.js';
import {
useIntentionalSaveMedia,
type IntentionalSaveMedia,
@@ -147,6 +146,7 @@
type BaseProps = {
+navigation: AppNavigationProp<'ImageModal'>,
+route: NavigationRoute<'ImageModal'>,
+ +children: React.Node,
};
type Props = {
...BaseProps,
@@ -1009,7 +1009,6 @@
}
render() {
- const { mediaInfo } = this.props.route.params;
const statusBar = FullScreenViewModal.isActive(this.props) ? (
<ConnectedStatusBar hidden />
) : null;
@@ -1041,7 +1040,7 @@
<Animated.View style={[styles.backdrop, backdropStyle]} />
<View style={this.contentContainerStyle}>
<Animated.View style={this.imageContainerStyle}>
- <Multimedia mediaInfo={mediaInfo} spinnerColor="white" />
+ {this.props.children}
</Animated.View>
</View>
<SafeAreaView style={styles.buttonsOverlay}>
@@ -1127,6 +1126,7 @@
this.props.navigation.goBackOnce();
};
+ // this can be lifted and optional
save = () => {
const { mediaInfo, item } = this.props.route.params;
invariant(
@@ -1140,6 +1140,7 @@
return this.props.intentionalSaveMedia(uri, ids);
};
+ // this can be lifted and optional
copy = () => {
const { uri } = this.props.route.params.mediaInfo;
Clipboard.setImageFromURL(uri, success => {
diff --git a/native/media/image-modal.react.js b/native/media/image-modal.react.js
--- a/native/media/image-modal.react.js
+++ b/native/media/image-modal.react.js
@@ -4,6 +4,7 @@
import { type MediaInfo } from 'lib/types/media-types.js';
+import Multimedia from './multimedia.react.js';
import FullScreenViewModal from '../components/full-screen-view-modal.react.js';
import type { AppNavigationProp } from '../navigation/app-navigator.react.js';
import type { NavigationRoute } from '../navigation/route-names.js';
@@ -29,7 +30,11 @@
function ImageModal(props: Props): React.Node {
const { navigation, route } = props;
- return <FullScreenViewModal navigation={navigation} route={route} />;
+ return (
+ <FullScreenViewModal navigation={navigation} route={route}>
+ <Multimedia mediaInfo={route.params.mediaInfo} spinnerColor="white" />
+ </FullScreenViewModal>
+ );
}
export default ImageModal;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Dec 10, 10:47 AM (18 h, 25 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5863334
Default Alt Text
D9359.1765363627.diff (2 KB)
Attached To
Mode
D9359: [native] introduce children prop to FullScreenViewModal
Attached
Detach File
Event Timeline
Log In to Comment