Page MenuHomePhabricator
Files F3353142

D3919.diff
No OneTemporary
Actions

D3919.diff
View Options

diff --git a/keyserver/src/socket/socket.js b/keyserver/src/socket/socket.js
--- a/keyserver/src/socket/socket.js
+++ b/keyserver/src/socket/socket.js
@@ -473,9 +473,10 @@
updatesCurrentAsOf: oldUpdatesCurrentAsOf,
};
if (viewer.sessionChanged) {
- // If initializeSession encounters sessionIdentifierTypes.BODY_SESSION_ID,
- // but the session is unspecified or expired, it will set a new sessionID
- // and specify viewer.sessionChanged
+ // If initializeSession encounters,
+ // sessionIdentifierTypes.BODY_SESSION_ID but the session
+ // is unspecified or expired,
+ // it will set a new sessionID and specify viewer.sessionChanged
const { sessionID } = viewer;
invariant(
sessionID !== null && sessionID !== undefined,
diff --git a/lib/shared/messages/text-message-spec.js b/lib/shared/messages/text-message-spec.js
--- a/lib/shared/messages/text-message-spec.js
+++ b/lib/shared/messages/text-message-spec.js
@@ -27,8 +27,9 @@
import { assertSingleMessageInfo } from './utils';
/**
- * most of the markdown leaves contain `content` field (it is an array or a string)
- * apart from lists, which have `items` field (that holds an array)
+ * most of the markdown leaves contain `content` field
+ * (it is an array or a string) apart from lists,
+ * which have `items` field (that holds an array)
*/
const rawTextFromMarkdownAST = (node: ASTNode): string => {
if (Array.isArray(node)) {
diff --git a/lib/utils/fetch-json.js b/lib/utils/fetch-json.js
--- a/lib/utils/fetch-json.js
+++ b/lib/utils/fetch-json.js
@@ -127,17 +127,17 @@
if (getConfig().setCookieOnRequest) {
// We make sure that if setCookieOnRequest is true, we never set cookie to
// undefined. null has a special meaning here: we don't currently have a
- // cookie, and we want the server to specify the new cookie it will generate
- // in the response body rather than the response header. See
- // session-types.js for more details on why we specify cookies in the body.
+ // cookie, and we want the server to specify the new cookie it will
+ // generate in the response body rather than the response header. See
+ // session-types.js for more details on why we specify cookies in the body
mergedData.cookie = cookie ? cookie : null;
}
if (getConfig().setSessionIDOnRequest) {
// We make sure that if setSessionIDOnRequest is true, we never set
// sessionID to undefined. null has a special meaning here: we cannot
// consider the cookieID to be a unique session identifier, but we do not
- // have a sessionID to use either. This should only happen when the user is
- // not logged in on web.
+ // have a sessionID to use either. This should only happen when the user
+ // is not logged in on web.
mergedData.sessionID = sessionID ? sessionID : null;
}
const fetchPromise = (async (): Promise<FetchJSONServerResponse> => {
diff --git a/native/chat/chat-input-bar.react.js b/native/chat/chat-input-bar.react.js
--- a/native/chat/chat-input-bar.react.js
+++ b/native/chat/chat-input-bar.react.js
@@ -391,10 +391,12 @@
if (threadHasPermission(this.props.threadInfo, threadPermissions.VOICED)) {
return true;
}
- // If the thread is created by somebody else while the viewer is attempting to
- // create it, the threadInfo might be modified in-place and won't list the
- // viewer as a member, which will end up hiding the input. In this case, we will
- // assume that our creation action will get translated into a join, and as long
+ // If the thread is created by somebody else while the viewer is attempting
+ // to create it, the threadInfo might be modified in-place
+ // and won't list the viewer as a member,
+ // which will end up hiding the input.
+ // In this case, we will assume that our creation action
+ // will get translated into a join, and as long
// as members are voiced, we can show the input.
if (!this.props.threadCreationInProgress) {
return false;
diff --git a/native/chat/chat-thread-list.react.js b/native/chat/chat-thread-list.react.js
--- a/native/chat/chat-thread-list.react.js
+++ b/native/chat/chat-thread-list.react.js
@@ -363,8 +363,8 @@
}
// itemHeight for emptyItem might be wrong because of line wrapping
- // but we don't care because we'll only ever be rendering this item by itself
- // and it should always be on-screen
+ // but we don't care because we'll only ever be rendering this item
+ // by itself and it should always be on-screen
if (item.type === 'empty') {
return 123;
}
diff --git a/native/navigation/overlay-navigator.react.js b/native/navigation/overlay-navigator.react.js
--- a/native/navigation/overlay-navigator.react.js
+++ b/native/navigation/overlay-navigator.react.js
@@ -361,9 +361,10 @@
pendingAnimationsRef.current = {};
}, [positions, pendingAnimations]);
- // If sceneData changes, we update scrollBlockingModalStatus based on it, both
- // in state and within the individual sceneData contexts. If sceneData doesn't
- // change, it's still possible for scrollBlockingModalStatus to change via the
+ // If sceneData changes, we update scrollBlockingModalStatus based on it,
+ // both in state and within the individual sceneData contexts.
+ // If sceneData doesn't change,
+ // it's still possible for scrollBlockingModalStatus to change via the
// setScrollBlockingModalStatus callback we expose via context
let newScrollBlockingModalStatus;
if (sceneDataChanged || sceneData !== prevSceneData) {
@@ -405,7 +406,8 @@
setSceneData(updatedSceneData);
}
- // Usually this would be done in an effect, but calling setState from the body
+ // Usually this would be done in an effect,
+ // but calling setState from the body
// of a hook causes the hook to rerender before triggering effects. To avoid
// infinite loops we make sure to set our prev values after we finish
// comparing them
diff --git a/native/types/themes.js b/native/types/themes.js
--- a/native/types/themes.js
+++ b/native/types/themes.js
@@ -19,6 +19,7 @@
// revert to `activeTheme: osCanTheme ? null : 'light'` to re-enable theming
activeTheme: 'dark',
systemTheme: null,
- // revert to `preference: osCanTheme ? 'system' : 'light'` to re-enable theming
+ // revert to `preference: osCanTheme ? 'system' : 'light'`
+ // to re-enable theming
preference: 'dark',
};
diff --git a/native/utils/dev-hostname.js b/native/utils/dev-hostname.js
--- a/native/utils/dev-hostname.js
+++ b/native/utils/dev-hostname.js
@@ -7,7 +7,8 @@
try {
// this is your machine's hostname in the local network
// usually it looks like this: 192.168.1.x
- // to find it you may want to use `ifconfig | grep '192.168'` command in the terminal
+ // to find it you may want to use `ifconfig | grep '192.168'`
+ // command in the terminal
// example of native/facts/network.json:
// { "natDevHostname": "192.168.1.x" }
// $FlowExpectedError: That's a conditional require so the file may not exist
diff --git a/web/chat/chat-input-bar.react.js b/web/chat/chat-input-bar.react.js
--- a/web/chat/chat-input-bar.react.js
+++ b/web/chat/chat-input-bar.react.js
@@ -213,11 +213,11 @@
) : null;
let content;
- // If the thread is created by somebody else while the viewer is attempting to
- // create it, the threadInfo might be modified in-place and won't list the
- // viewer as a member, which will end up hiding the input. In this case, we will
- // assume that our creation action will get translated into a join, and as long
- // as members are voiced, we can show the input.
+ // If the thread is created by somebody else while the viewer is attempting
+ // to create it, the threadInfo might be modified in-place and won't
+ // list the viewer as a member, which will end up hiding the input. In
+ // this case, we will assume that our creation action will get translated,
+ // into a join and as long as members are voiced, we can show the input.
const defaultMembersAreVoiced = checkIfDefaultMembersAreVoiced(
this.props.threadInfo,
);

File Metadata

Mime Type
text/plain
Expires
Sun, Nov 24, 8:35 AM (19 h, 25 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2570904
Default Alt Text
D3919.diff (8 KB)

Event Timeline