Page MenuHomePhabricator
Files F3387647

D4071.id13220.diff
No OneTemporary
Actions

D4071.id13220.diff
View Options

diff --git a/keyserver/src/database/migrations.js b/keyserver/src/database/migrations.js
--- a/keyserver/src/database/migrations.js
+++ b/keyserver/src/database/migrations.js
@@ -3,8 +3,11 @@
import fs from 'fs';
import type { QueryResults } from 'mysql';
+import { isDev } from 'lib/utils/dev-utils';
import { getMessageForException } from 'lib/utils/errors';
+import sleep from 'lib/utils/sleep';
+import { updateRolesAndPermissionsForAllThreads } from '../updaters/thread-permission-updaters';
import { dbQuery, SQL } from './database';
async function makeSureBaseRoutePathExists(filePath: string): Promise<void> {
@@ -85,6 +88,7 @@
await fixBaseRoutePathForLocalhost('facts/squadcal_url.json');
},
],
+ [3, updateRolesAndPermissionsForAllThreads],
]);
async function migrate(): Promise<boolean> {
@@ -98,6 +102,12 @@
return false;
}
+ // Delay to avoid executing migration before nodemon restarts server
+ // while transpiling files during dev environment startup.
+ if (isDev) {
+ await sleep(5000);
+ }
+
for (const [idx, migration] of migrations.entries()) {
if (idx <= dbVersion) {
continue;
diff --git a/keyserver/src/updaters/thread-permission-updaters.js b/keyserver/src/updaters/thread-permission-updaters.js
--- a/keyserver/src/updaters/thread-permission-updaters.js
+++ b/keyserver/src/updaters/thread-permission-updaters.js
@@ -38,6 +38,7 @@
import { rescindPushNotifs } from '../push/rescind';
import { createScriptViewer } from '../session/scripts';
import type { Viewer } from '../session/viewer';
+import { updateRoles } from '../updaters/role-updaters';
import DepthQueue from '../utils/depth-queue';
import RelationshipChangeset from '../utils/relationship-changeset';
import { updateChangedUndirectedRelationships } from './relationship-updaters';
@@ -1238,6 +1239,51 @@
}
}
+async function updateRolesAndPermissionsForAllThreads() {
+ const batchSize = 10;
+ const fetchThreads = SQL`SELECT id, type, depth FROM threads`;
+ const [result] = await dbQuery(fetchThreads);
+ const allThreads = result.map(row => {
+ return {
+ id: row.id.toString(),
+ type: assertThreadType(row.type),
+ depth: row.depth,
+ };
+ });
+
+ const viewer = createScriptViewer(bots.commbot.userID);
+
+ const maxDepth = Math.max(...allThreads.map(row => row.depth));
+
+ for (let depth = 0; depth <= maxDepth; depth++) {
+ const threads = allThreads.filter(row => row.depth === depth);
+ console.log(`recalculating permissions for threads with depth ${depth}`);
+ while (threads.length > 0) {
+ const batch = threads.splice(0, batchSize);
+ const membershipRows = [];
+ const relationshipChangeset = new RelationshipChangeset();
+ await Promise.all(
+ batch.map(async thread => {
+ console.log(`updating roles for ${thread.id}`);
+ await updateRoles(viewer, thread.id, thread.type);
+ console.log(`recalculating permissions for ${thread.id}`);
+ const {
+ membershipRows: threadMembershipRows,
+ relationshipChangeset: threadRelationshipChangeset,
+ } = await recalculateThreadPermissions(thread.id);
+ membershipRows.push(...threadMembershipRows);
+ relationshipChangeset.addAll(threadRelationshipChangeset);
+ }),
+ );
+ console.log(`committing batch ${JSON.stringify(batch)}`);
+ await commitMembershipChangeset(viewer, {
+ membershipRows,
+ relationshipChangeset,
+ });
+ }
+ }
+}
+
export {
changeRole,
recalculateThreadPermissions,
@@ -1245,4 +1291,5 @@
saveMemberships,
commitMembershipChangeset,
recalculateAllThreadPermissions,
+ updateRolesAndPermissionsForAllThreads,
};

File Metadata

Mime Type
text/plain
Expires
Sat, Nov 30, 10:31 AM (21 h, 34 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2600587
Default Alt Text
D4071.id13220.diff (3 KB)

Event Timeline