Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3388325
D8576.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D8576.diff
View Options
diff --git a/native/chat/inline-engagement.react.js b/native/chat/inline-engagement.react.js
--- a/native/chat/inline-engagement.react.js
+++ b/native/chat/inline-engagement.react.js
@@ -30,16 +30,16 @@
type Props = {
+sidebarThreadInfo: ?ThreadInfo,
- +reactions?: ReactionInfo,
+ +reactions: ReactionInfo,
+disabled?: boolean,
+positioning?: 'left' | 'right' | 'center',
+label?: ?string,
};
function InlineEngagement(props: Props): React.Node {
const {
- disabled = false,
- reactions,
sidebarThreadInfo,
+ reactions,
+ disabled = false,
positioning,
label,
} = props;
@@ -88,7 +88,7 @@
const sidebarStyle = React.useMemo(() => {
const stylesResult = [styles.sidebar];
- if (!reactions || Object.keys(reactions).length === 0) {
+ if (Object.keys(reactions).length === 0) {
return stylesResult;
}
@@ -155,7 +155,7 @@
]);
const reactionList = React.useMemo(() => {
- if (!reactions || Object.keys(reactions).length === 0) {
+ if (Object.keys(reactions).length === 0) {
return null;
}
@@ -366,6 +366,7 @@
<Animated.View style={inlineEngagementStyles}>
<InlineEngagement
sidebarThreadInfo={item.threadCreatedFromMessage}
+ reactions={item.reactions}
disabled
/>
</Animated.View>
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 30, 1:44 PM (22 h, 5 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2601163
Default Alt Text
D8576.diff (1 KB)
Attached To
Mode
D8576: [native] make reactions prop for InlineEngagement requried
Attached
Detach File
Event Timeline
Log In to Comment