Page MenuHomePhabricator
Files F3391656

D3563.id12423.diff
No OneTemporary
Actions

D3563.id12423.diff
View Options

diff --git a/native/push/push-handler.react.js b/native/push/push-handler.react.js
--- a/native/push/push-handler.react.js
+++ b/native/push/push-handler.react.js
@@ -389,12 +389,12 @@
const deviceType = Platform.OS;
if (deviceType === 'ios') {
iosPushPermissionResponseReceived();
- if (__DEV__) {
- // iOS simulator can't handle notifs
- return;
- }
+ } else {
+ this.showNotifAlertOnAndroid();
}
+ };
+ showNotifAlertOnAndroid() {
const alertInfo = this.props.notifPermissionAlertInfo;
if (
(alertInfo.totalAlerts > 3 &&
@@ -411,24 +411,15 @@
payload: { time: Date.now() },
});
- if (deviceType === 'ios') {
- Alert.alert(
- 'Need notif permissions',
- 'Comm needs notification permissions to keep you in the loop! ' +
- 'Please enable in Settings App -> Notifications -> Comm.',
- [{ text: 'OK' }],
- );
- } else if (deviceType === 'android') {
- Alert.alert(
- 'Unable to initialize notifs!',
- 'Please check your network connection, make sure Google Play ' +
- 'services are installed and enabled, and confirm that your Google ' +
- 'Play credentials are valid in the Google Play Store.',
- undefined,
- { cancelable: true },
- );
- }
- };
+ Alert.alert(
+ 'Unable to initialize notifs!',
+ 'Please check your network connection, make sure Google Play ' +
+ 'services are installed and enabled, and confirm that your Google ' +
+ 'Play credentials are valid in the Google Play Store.',
+ undefined,
+ { cancelable: true },
+ );
+ }
navigateToThread(threadInfo: ThreadInfo, clearChatRoutes: boolean) {
if (clearChatRoutes) {

File Metadata

Mime Type
text/plain
Expires
Sun, Dec 1, 5:14 AM (16 h, 3 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2603770
Default Alt Text
D3563.id12423.diff (1 KB)

Event Timeline