Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3395669
D6814.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D6814.diff
View Options
diff --git a/lib/utils/url-utils.js b/lib/utils/url-utils.js
--- a/lib/utils/url-utils.js
+++ b/lib/utils/url-utils.js
@@ -8,7 +8,6 @@
+verify?: string,
+calendar?: boolean,
+chat?: boolean,
- +apps?: boolean,
+thread?: string,
+settings?: 'account' | 'danger-zone',
+threadCreation?: boolean,
@@ -24,7 +23,6 @@
const verifyRegex = new RegExp('(/|^)verify/([a-f0-9]+)(/|$)', 'i');
const calendarRegex = new RegExp('(/|^)calendar(/|$)', 'i');
const chatRegex = new RegExp('(/|^)chat(/|$)', 'i');
-const appsRegex = new RegExp('(/|^)apps(/|$)', 'i');
const accountSettingsRegex = new RegExp('(/|^)settings/account(/|$)', 'i');
const dangerZoneRegex = new RegExp('(/|^)settings/danger-zone(/|$)', 'i');
const threadPendingRegex = new RegExp(
@@ -43,7 +41,6 @@
const verifyMatches = verifyRegex.exec(url);
const calendarTest = calendarRegex.test(url);
const chatTest = chatRegex.test(url);
- const appsTest = appsRegex.test(url);
const accountSettingsTest = accountSettingsRegex.test(url);
const dangerZoneTest = dangerZoneRegex.test(url);
const threadPendingMatches = threadPendingRegex.exec(url);
@@ -77,8 +74,6 @@
returnObj.calendar = true;
} else if (chatTest) {
returnObj.chat = true;
- } else if (appsTest) {
- returnObj.apps = true;
} else if (accountSettingsTest) {
returnObj.settings = 'account';
} else if (dangerZoneTest) {
diff --git a/web/app.react.js b/web/app.react.js
--- a/web/app.react.js
+++ b/web/app.react.js
@@ -38,7 +38,6 @@
import InputStateContainer from './input/input-state-container.react.js';
import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js';
-import AppsDirectory from './modals/apps/apps-directory-modal.react.js';
import UpdateModalHandler from './modals/update-modal.react.js';
import SettingsSwitcher from './navigation-panels/settings-switcher.react.js';
import Topbar from './navigation-panels/topbar.react.js';
@@ -258,8 +257,6 @@
mainContent = <Calendar url={this.props.location.pathname} />;
} else if (tab === 'chat') {
mainContent = <Chat />;
- } else if (tab === 'apps') {
- mainContent = <AppsDirectory />;
}
const mainContentClass = classnames(
diff --git a/web/sidebar/community-picker.react.js b/web/sidebar/community-picker.react.js
--- a/web/sidebar/community-picker.react.js
+++ b/web/sidebar/community-picker.react.js
@@ -49,10 +49,7 @@
const inboxButtonTitle = isCalendarOpen ? 'All communities' : 'Inbox';
const isInboxOpen = useSelector(
- state =>
- state.navInfo.tab === 'chat' ||
- state.navInfo.tab === 'apps' ||
- state.navInfo.tab === 'calendar',
+ state => state.navInfo.tab === 'chat' || state.navInfo.tab === 'calendar',
);
const isSettingsOpen = useSelector(state => state.navInfo.tab === 'settings');
diff --git a/web/types/nav-types.js b/web/types/nav-types.js
--- a/web/types/nav-types.js
+++ b/web/types/nav-types.js
@@ -3,7 +3,7 @@
import type { BaseNavInfo } from 'lib/types/nav-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js';
-export type NavigationTab = 'calendar' | 'chat' | 'apps' | 'settings';
+export type NavigationTab = 'calendar' | 'chat' | 'settings';
export type NavigationSettingsSection = 'account' | 'danger-zone';
diff --git a/web/url-utils.js b/web/url-utils.js
--- a/web/url-utils.js
+++ b/web/url-utils.js
@@ -108,8 +108,6 @@
let tab = 'chat';
if (urlInfo.calendar) {
tab = 'calendar';
- } else if (urlInfo.apps) {
- tab = 'apps';
} else if (urlInfo.settings) {
tab = 'settings';
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Dec 2, 6:51 AM (18 h, 8 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2606924
Default Alt Text
D6814.diff (3 KB)
Attached To
Mode
D6814: [web] Remove apps as a tab in code logic
Attached
Detach File
Event Timeline
Log In to Comment