Paths

Table of Contentst

[web] Memoize `Chat` component
ClosedPublic
Actions

Authored by • jacek on Apr 29 2022, 7:05 AM.

Tags

None

Referenced Files

	F3392576: D3877.id12117.diff
	Sat, Nov 30, 9:15 AM

	F3392571: D3877.id12326.diff
	Sat, Nov 30, 9:15 AM

	Unknown Object (File)
	Wed, Nov 27, 8:56 AM

	Unknown Object (File)
	Fri, Nov 22, 10:03 AM

	Unknown Object (File)
	Sun, Nov 10, 12:39 AM

	Unknown Object (File)
	Fri, Nov 8, 8:21 PM

	Unknown Object (File)
	Fri, Nov 8, 8:21 PM

	Unknown Object (File)
	Fri, Nov 8, 8:21 PM

Subscribers

Details

Reviewers

tomek
atul
• benschac

Commits

rCOMMb79a177080f0: [web] Memoize `Chat` component

Summary

Memoize Chat component to improve performance as described in:
https://linear.app/comm/issue/ENG-1062/add-memoization-to-chat-component-in-web

Test Plan

Run web app, tested the performance when opening modals and checked if app behavior remains unchanged.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Apr 29 2022, 7:05 AM

Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald TranscriptApr 29 2022, 7:05 AM

• jacek added reviewers: atul, • benschac.Apr 29 2022, 7:06 AM

Harbormaster completed remote builds in B8698: Diff 12117.Apr 29 2022, 7:09 AM

• jacek requested review of this revision.Apr 29 2022, 7:09 AM

tomek accepted this revision.Apr 29 2022, 7:48 AM

This revision is now accepted and ready to land.Apr 29 2022, 7:48 AM

rebase

Harbormaster completed remote builds in B8837: Diff 12321.May 6 2022, 1:43 AM

Closed by commit rCOMMb79a177080f0: [web] Memoize `Chat` component (authored by • jacek). · Explain WhyMay 6 2022, 1:45 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMMb79a177080f0: [web] Memoize `Chat` component.

• karol removed a subscriber: • karol.May 6 2022, 3:54 AM

Revision Contents
Changeset List

Path

Size

web/

chat/

chat.react.js

4 lines

Diff 12326

View Options

[web] Memoize `Chat` componentClosedPublicActions