Page MenuHomePhabricator

[web] Introduce account delete modal
ClosedPublic

Authored by tomek on May 24 2022, 8:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 5:30 PM
Unknown Object (File)
Wed, Nov 27, 5:27 PM
Unknown Object (File)
Wed, Nov 27, 3:48 PM
Unknown Object (File)
Sat, Nov 23, 11:03 PM
Unknown Object (File)
Fri, Nov 8, 11:25 PM
Unknown Object (File)
Fri, Nov 8, 12:49 PM
Unknown Object (File)
Fri, Nov 8, 12:49 PM
Unknown Object (File)
Oct 28 2024, 3:02 AM

Details

Summary

This modal contains a part of the logic from user settings modal, so it is a good idea to reuse what we already have there. The first step is to simply copy the content of that modal (with naming and import changes) - we can do that, because the last step of this stack will be to delete the original modal which will get rid of the duplication.

This is the first step in adding the modal, introduced mainly to allow easier review of the code - so that it is clear which parts stay and which are not needed.

delete_account_1.png (1×1 px, 156 KB)

Test Plan

Modify danger-zone so that the modal is displayed after user clicks Delete Account button. A modal that looks like user settings should be displayed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.May 24 2022, 8:34 AM

Gotcha, so the goal is to copy over the existing UserSettingsModal which has the functionality we need, subtract the parts that are no longer relevant, and then style/refactor off of what we already know works?

This revision is now accepted and ready to land.May 24 2022, 8:36 AM
In D4117#116360, @atul wrote:

Gotcha, so the goal is to copy over the existing UserSettingsModal which has the functionality we need, subtract the parts that are no longer relevant, and then style/refactor off of what we already know works?

Yes, exactly. After this stack the settings modal would no longer be needed so we can delete it.

This revision was automatically updated to reflect the committed changes.