Page MenuHomePhabricator
Differential D4243

[native] [web] Use `tinycolor` when comparing colors represented as strings
ClosedPublic
Actions

Authored by • abosh on Jun 9 2022, 2:29 PM.
Tags
None
Referenced Files
F3392172: D4243.diff
Sat, Nov 30, 7:18 AM
Unknown Object (File)
Thu, Nov 28, 3:30 AM
Unknown Object (File)
Wed, Nov 27, 9:46 AM
Unknown Object (File)
Wed, Nov 27, 9:35 AM
Unknown Object (File)
Sat, Nov 9, 11:41 AM
Unknown Object (File)
Sat, Nov 9, 11:41 AM
Unknown Object (File)
Fri, Nov 8, 12:47 PM
Unknown Object (File)
Fri, Nov 8, 8:08 AM
View All Files
Subscribers
• adrian
ashoat
tomek

Details

Reviewers
atul
Commits
rCOMM139c314bd1ce: [native] [web] Use `tinycolor` when comparing colors represented as strings
Summary

Recently have run into some bugs with checking color equality between two hex strings (using the basic === operator). Changed this equality (or inequality) check to use tinycolor.equals() instead throughout the codebase.

Test Plan

Tested LoadingIndicator and ThreadSettings on web and ensured that they looked as expected after the change.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• abosh created this revision.Jun 9 2022, 2:29 PM
Herald added subscribers: • adrian, tomek, ashoat. · View Herald TranscriptJun 9 2022, 2:29 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 9 2022, 2:30 PM
Harbormaster failed remote builds in B9704: Diff 13445!
• abosh edited the summary of this revision. (Show Details)Jun 9 2022, 2:30 PM
• abosh edited the test plan for this revision. (Show Details)
• abosh added 1 blocking reviewer(s): atul.
Harbormaster completed remote builds in B9704: Diff 13445.Jun 10 2022, 4:19 PM
• abosh requested review of this revision.Jun 10 2022, 4:19 PM
• abosh added inline comments.Jun 10 2022, 5:07 PM
web/calendar/entry.react.js
198

This change is just a minor style fix that corrects the prior string concatenation to use ${} placeholder syntax (used throughout the codebase).

atul accepted this revision.Jun 14 2022, 12:29 PM
This revision is now accepted and ready to land.Jun 14 2022, 12:29 PM
Closed by commit rCOMM139c314bd1ce: [native] [web] Use `tinycolor` when comparing colors represented as strings (authored by • abosh). · Explain WhyJun 14 2022, 12:58 PM
This revision was automatically updated to reflect the committed changes.
• abosh added a commit: rCOMM139c314bd1ce: [native] [web] Use `tinycolor` when comparing colors represented as strings.

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
5 lines
web/
calendar/
2 lines
6 lines

Diff 13445

View Options

native/chat/settings/thread-settings.react.js

Loading...
View Options

web/calendar/entry.react.js

Loading...
View Options

web/loading-indicator.react.js

Loading...