Returns the userID String if present, otherwise returns the appropriate error
Depends on D4648
Details
Details
Tested in subsequent diff that uses helper
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/identity/src/database.rs | ||
|---|---|---|
| 403–419 ↗ | (On Diff #15025) | The code isn't specific to user_id: this name is used only as a name in match statement. Maybe we can make this method more generic by changing its name to e.g. parse_attribute_value? We can also consider making this an implementation of Into<String> (not sure if this is possible, as we're converting Option<AttributeValue>). One issue is error handling. For more generic name, we could introduce a new parameter with keyName. For Into I don't see how we could have this handling... maybe Into<Result<String, DBItemError>>? Overall, my point is that this code would be repeated a lot of times if we want to have similar functions for other AttributeValues. It would be great if we could avoid this. |
| services/identity/src/database.rs | ||
|---|---|---|
| 403–419 ↗ | (On Diff #15025) | I'll make this more general before landing |
| services/identity/src/database.rs | ||
|---|---|---|
| 403–419 ↗ | (On Diff #15025) | Ah, sorry, it is updated, but not fully. We still use user_id name which is now incorrect. |
| services/identity/src/database.rs | ||
|---|---|---|
| 403–419 ↗ | (On Diff #15025) | ah, oops, will fix now |