Page MenuHomePhabricator
Differential D4993

[Shared/docs] Update `yarn codegen-grpc`
ClosedPublic
Actions

Authored by • jon on Aug 31 2022, 10:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 8:38 PM
Unknown Object (File)
Mon, Nov 25, 8:33 PM
Unknown Object (File)
Mon, Nov 25, 8:20 PM
Unknown Object (File)
Mon, Nov 18, 10:43 AM
Unknown Object (File)
Oct 30 2024, 4:22 AM
Unknown Object (File)
Oct 26 2024, 2:15 AM
Unknown Object (File)
Oct 26 2024, 2:15 AM
Unknown Object (File)
Oct 26 2024, 2:15 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
varun
• abosh
• max
• karol
Commits
rCOMMaa48f7b7befb: [Shared/docs] Update `yarn codegen-grpc`
Summary

Update yarn workflow for updating codegen-grpc

https://linear.app/comm/issue/ENG-1231

Depends on D4992

Test Plan
# should get re-generated
rm shared/protos/_generated/blob.grpc.pb.cc

cd shared
yarn codegen-grpc

# assert blob gets regenerated
git status # should be empty

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 31 2022, 10:31 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 31 2022, 10:31 AM
• jon edited the summary of this revision. (Show Details)Aug 31 2022, 10:39 AM
• jon added a parent revision: D4992: [Shared] Copy protos to shared/protos, adjust CMake.
• jon added a child revision: D4994: [Android] Update reference to protobuf files.
Harbormaster completed remote builds in B11736: Diff 16127.Aug 31 2022, 10:41 AM
• jon requested review of this revision.Aug 31 2022, 10:41 AM
• max accepted this revision.Aug 31 2022, 5:01 PM
This revision is now accepted and ready to land.Aug 31 2022, 5:01 PM
• jon updated this revision to Diff 16266.Sep 2 2022, 3:23 PM

Rebase on top of latest master

Harbormaster completed remote builds in B11853: Diff 16266.Sep 2 2022, 3:34 PM
• jon added a child revision: D5046: [Native] Remove old protos and related files.Sep 2 2022, 5:41 PM
• jon updated this revision to Diff 16417.Sep 7 2022, 9:41 AM

Rebase on master

Harbormaster failed remote builds in B11963: Diff 16417!Sep 7 2022, 9:52 AM
Harbormaster completed remote builds in B11963: Diff 16417.Sep 7 2022, 9:57 AM
Closed by commit rCOMMaa48f7b7befb: [Shared/docs] Update `yarn codegen-grpc` (authored by • jon). · Explain WhySep 8 2022, 10:29 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMaa48f7b7befb: [Shared/docs] Update `yarn codegen-grpc`.

Revision Contents
Changeset List

PathSize
docs/
2 lines
native/
scripts/
shared/
9 lines
scripts/

Diff 16417

View Options

docs/dev_environment.md

Loading...
View Options

native/scripts/mark-generated.sh

Loading...
View Options

shared/package.json

Loading...
View Options

shared/scripts/mark-generated.sh

Loading...