Paths

Table of Contentst

Differential D5579

[native] refactor CommCoreModule to allow cancellable tasks
ClosedPublic
Actions

Authored by kamil on Nov 9 2022, 3:12 AM.

Tags

None

Referenced Files

	F3396451: D5579.id18258.diff
	Sun, Dec 1, 12:23 PM

	F3395850: D5579.id18650.diff
	Sun, Dec 1, 8:09 AM

	F3395763: D5579.diff
	Sun, Dec 1, 7:29 AM

	Unknown Object (File)
	Fri, Nov 29, 12:36 AM

	Unknown Object (File)
	Fri, Nov 29, 12:25 AM

	Unknown Object (File)
	Thu, Nov 21, 3:18 PM

	Unknown Object (File)
	Sun, Nov 3, 11:25 PM

	Unknown Object (File)
	Oct 25 2024, 5:18 PM

Subscribers

Details

Reviewers

marcin
• jon
tomek
atul

Commits

rCOMM615b98191857: [native] refactor CommCoreModule to allow cancellable tasks

Summary

context: ENG-2139

refactor CommCoreModule methods that schedule tasks on the database thread to allow them to be canceled - all methods except clearSensitiveData that should not be canceled - is responsible for canceling others.

Test Plan

Build app for both iOS and Android
Check if previous integrations with the database work properly eg. by adding some drafts etc.
Make sure that there is no operation executed on database thread or added to queue when sensitiveDataCleaner is called

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 9 2022, 3:12 AM

kamil held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptNov 9 2022, 3:12 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B13309: Diff 18257.Nov 9 2022, 3:23 AM

add setDeviceId to refactored tasks

kamil edited the summary of this revision. (Show Details)Nov 9 2022, 3:28 AM

Harbormaster completed remote builds in B13310: Diff 18258.Nov 9 2022, 3:36 AM

kamil added a parent revision: D5578: [native] implement method to run asynchronous cancellable task in CommCoreModule and return error via promise.Nov 9 2022, 3:40 AM

kamil edited the summary of this revision. (Show Details)Nov 10 2022, 6:55 AM

kamil edited the test plan for this revision. (Show Details)

kamil edited parent revisions, added: D5594: [native] introduce error handling to cover cancelled database tasks; removed: D5578: [native] implement method to run asynchronous cancellable task in CommCoreModule and return error via promise.

kamil mentioned this in D5577: [native] implement method to run synchronous cancellable task in CommCoreModule.Nov 10 2022, 7:23 AM

kamil published this revision for review.Nov 10 2022, 7:42 AM

rebase

Harbormaster completed remote builds in B13402: Diff 18377.Nov 11 2022, 6:04 AM

marcin accepted this revision.Nov 14 2022, 2:38 AM

marcin added a reviewer: tomek.

tomek accepted this revision.Nov 14 2022, 10:27 AM

This revision is now accepted and ready to land.Nov 14 2022, 10:27 AM

rebase

kamil added a reviewer: atul.Nov 16 2022, 2:42 AM

This revision now requires review to proceed.Nov 16 2022, 2:42 AM

Harbormaster completed remote builds in B13457: Diff 18456.Nov 16 2022, 2:53 AM

(Removing myself as blocking since I don't think I have enough context to give this a proper review)

This revision is now accepted and ready to land.Nov 17 2022, 9:21 AM

rebase before landing

Harbormaster completed remote builds in B13603: Diff 18632.Nov 21 2022, 2:19 AM

Closed by commit rCOMM615b98191857: [native] refactor CommCoreModule to allow cancellable tasks (authored by kamil). · Explain WhyNov 21 2022, 3:42 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM615b98191857: [native] refactor CommCoreModule to allow cancellable tasks.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

136 lines

Diff 18650

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...