Page MenuHomePhabricator
Differential D6005

[lib/keyserver/native] move all the reaction message types into its own file
ClosedPublic
Actions

Authored by ginsu on Dec 22 2022, 3:29 PM.
Tags
None
Referenced Files
F3390924: D6005.id20389.diff
Sat, Nov 30, 1:33 AM
Unknown Object (File)
Thu, Nov 28, 10:34 PM
Unknown Object (File)
Mon, Nov 11, 4:36 PM
Unknown Object (File)
Mon, Nov 11, 2:08 PM
Unknown Object (File)
Fri, Nov 8, 5:16 PM
Unknown Object (File)
Fri, Nov 8, 5:15 PM
Unknown Object (File)
Fri, Nov 8, 5:15 PM
Unknown Object (File)
Fri, Nov 8, 4:51 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
tomek
atul
Commits
rCOMM6a41bf47ea2a: [lib/keyserver/native] move all the reaction message types into its own file
Summary

I don't know why I didn't do this from the start, but moved ReactionMessageData RawReactionMessageInfo and ReactionMessageInfo into a reaction messages type file. Almost all the other message types do this as well

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
eng-2243 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 22 2022, 3:29 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 22 2022, 3:29 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 22 2022, 3:43 PM
Harbormaster failed remote builds in B14698: Diff 20039!
Harbormaster completed remote builds in B14698: Diff 20039.Dec 22 2022, 3:55 PM
ginsu requested review of this revision.Dec 22 2022, 3:55 PM
ginsu added reviewers: atul, tomek.Dec 27 2022, 7:08 AM
ginsu added a child revision: D6054: [lib/native] move useCanCreateReactionFromMessage hook from native to lib.Dec 27 2022, 7:14 AM
tomek accepted this revision.Dec 29 2022, 4:58 AM
atul resigned from this revision.Dec 29 2022, 12:47 PM

Resigning to unblock since this was reviewed by @tomek.

This revision is now accepted and ready to land.Dec 29 2022, 12:47 PM
Closed by commit rCOMM6a41bf47ea2a: [lib/keyserver/native] move all the reaction message types into its own file (authored by ginsu). · Explain WhyDec 29 2022, 1:01 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6a41bf47ea2a: [lib/keyserver/native] move all the reaction message types into its own file.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
2 lines
lib/
shared/
2 lines
messages/
8 lines
types/
31 lines
messages/
29 lines
2 lines
native/
chat/
2 lines

Diff 20039

View Options

keyserver/src/responders/message-responders.js

Loading...
View Options

lib/shared/message-utils.js

Loading...
View Options

lib/shared/messages/reaction-message-spec.js

Loading...
View Options

lib/types/message-types.js

Loading...
View Options

lib/types/messages/reaction.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/chat/message-preview.react.js

Loading...