Page MenuHomePhabricator

[web][tests] Added package to fix tests
ClosedPublic

Authored by przemek on Jan 11 2023, 6:23 AM.
Tags
None
Referenced Files
F3392913: D6230.diff
Sat, Nov 30, 10:33 AM
Unknown Object (File)
Thu, Nov 28, 4:27 AM
Unknown Object (File)
Sun, Nov 10, 4:25 AM
Unknown Object (File)
Sun, Nov 10, 4:25 AM
Unknown Object (File)
Sat, Nov 9, 12:00 PM
Unknown Object (File)
Wed, Nov 6, 6:32 AM
Unknown Object (File)
Wed, Nov 6, 6:32 AM
Unknown Object (File)
Tue, Nov 5, 4:29 AM
Subscribers

Details

Summary

Added identity-obj-proxy as discussed here: https://linear.app/comm/issue/ENG-2654/problems-with-jest
That's the way to deal with .css imports in tested .js files. Usually .js files contains utility that shouldn't import
css, but sometimes they do and that's what failed after yarn test in web.
After installing that and some modifications in jest config it works.
Addign @ashoat as a reviewer as I added deps. At some point we may want to add it in other directories too, if we'll need to ignore some imports.

Test Plan

Runned yarn test in web. Worked and tests passed instead of crashing.

Diff Detail

Repository
rCOMM Comm
Branch
fix/jest-fix-css-imports
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

przemek retitled this revision from [web][tests] Added pakcage to fix tests to [web][tests] Added package to fix tests.Jan 11 2023, 8:19 AM
This revision is now accepted and ready to land.Jan 11 2023, 8:51 AM