Page MenuHomePhabricator

[web] Remove LeftLayoutAside
ClosedPublic

Authored by inka on Jan 22 2023, 11:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 8:01 PM
Unknown Object (File)
Tue, Mar 12, 11:29 PM
Unknown Object (File)
Feb 18 2024, 3:50 AM
Unknown Object (File)
Feb 18 2024, 2:36 AM
Unknown Object (File)
Feb 18 2024, 2:27 AM
Unknown Object (File)
Feb 18 2024, 12:11 AM
Unknown Object (File)
Feb 17 2024, 9:26 PM
Unknown Object (File)
Feb 17 2024, 9:20 PM
Subscribers

Details

Summary

Since D6344 the LeftLayoutAside is obsolete. I'm removing it, and putting the CommunityPicker directly in the App component.
This also calls for removing the left-layout-aside.css, which I'll do in the next diff, as it requires some code to be moved somewhere else.

Test Plan

Run the web app, check that the sidebar displayes correctly.

Diff Detail

Repository
rCOMM Comm
Branch
inka/community_drawer_web
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Jan 22 2023, 11:19 AM
inka planned changes to this revision.Jan 23 2023, 5:58 AM
This revision is now accepted and ready to land.Jan 26 2023, 6:14 AM
This revision now requires review to proceed.Jan 27 2023, 2:13 AM
tomek added inline comments.
web/sidebar/left-layout-aside.css
8–34 ↗(On Diff #21214)

Can we rename the file?

This revision is now accepted and ready to land.Jan 31 2023, 7:20 AM
web/sidebar/left-layout-aside.css
8–34 ↗(On Diff #21214)

As mentioned in the summary, this requires some code to be moved around, so it's done in a separate diff D6361

This revision was automatically updated to reflect the committed changes.